Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace incorrect spelling of COMMITER with COMMITTER #192

Merged
merged 1 commit into from
Dec 15, 2022
Merged

Replace incorrect spelling of COMMITER with COMMITTER #192

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 10 additions & 10 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,16 +75,16 @@ You can also run this step directly with [Bitrise CLI](https://github.com/bitris
<details>
<summary>Outputs</summary>

| Environment Variable | Description |
| --- | --- |
| `GIT_CLONE_COMMIT_HASH` | SHA hash of the checked-out commit. |
| `GIT_CLONE_COMMIT_MESSAGE_SUBJECT` | Commit message of the checked-out commit. |
| `GIT_CLONE_COMMIT_MESSAGE_BODY` | Commit message body of the checked-out commit. |
| `GIT_CLONE_COMMIT_COUNT` | Commit count after checkout. Count will only work properly if no `--depth` option is set. If `--depth` is set then the history truncated to the specified number of commits. Count will **not** fail but will be the clone depth. |
| `GIT_CLONE_COMMIT_AUTHOR_NAME` | Author of the checked-out commit. |
| `GIT_CLONE_COMMIT_AUTHOR_EMAIL` | Email of the checked-out commit. |
| `GIT_CLONE_COMMIT_COMMITER_NAME` | Committer name of the checked-out commit. |
| `GIT_CLONE_COMMIT_COMMITER_EMAIL` | Email of the checked-out commit. |
| Environment Variable | Description |
|------------------------------------|------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------|
| `GIT_CLONE_COMMIT_HASH` | SHA hash of the checked-out commit. |
| `GIT_CLONE_COMMIT_MESSAGE_SUBJECT` | Commit message of the checked-out commit. |
| `GIT_CLONE_COMMIT_MESSAGE_BODY` | Commit message body of the checked-out commit. |
| `GIT_CLONE_COMMIT_COUNT` | Commit count after checkout. Count will only work properly if no `--depth` option is set. If `--depth` is set then the history truncated to the specified number of commits. Count will **not** fail but will be the clone depth. |
| `GIT_CLONE_COMMIT_AUTHOR_NAME` | Author of the checked-out commit. |
| `GIT_CLONE_COMMIT_AUTHOR_EMAIL` | Email of the checked-out commit. |
| `GIT_CLONE_COMMIT_COMMITTER_NAME` | Committer name of the checked-out commit. |
| `GIT_CLONE_COMMIT_COMMITTER_EMAIL` | Email of the checked-out commit. |
Comment on lines +78 to +87
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All these extra spaces are courtesy of GoLand, which added them automatically to normalize the Markdown table.

</details>

## 🙋 Contributing
Expand Down
12 changes: 6 additions & 6 deletions e2e/bitrise.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -517,8 +517,8 @@ workflows:
check "GIT_CLONE_COMMIT_COUNT" "25"
check "GIT_CLONE_COMMIT_AUTHOR_NAME" "Krisztian Dobmayer"
check "GIT_CLONE_COMMIT_AUTHOR_EMAIL" "[email protected]"
check "GIT_CLONE_COMMIT_COMMITER_NAME" "Krisztian Dobmayer"
check "GIT_CLONE_COMMIT_COMMITER_EMAIL" "[email protected]"
check "GIT_CLONE_COMMIT_COMMITTER_NAME" "Krisztian Dobmayer"
check "GIT_CLONE_COMMIT_COMMITTER_EMAIL" "[email protected]"

_check_too_long_message:
steps:
Expand Down Expand Up @@ -548,8 +548,8 @@ workflows:
echo "GIT_CLONE_COMMIT_COUNT: ${GIT_CLONE_COMMIT_COUNT}"
echo "GIT_CLONE_COMMIT_AUTHOR_NAME: ${GIT_CLONE_COMMIT_AUTHOR_NAME}"
echo "GIT_CLONE_COMMIT_AUTHOR_EMAIL: ${GIT_CLONE_COMMIT_AUTHOR_EMAIL}"
echo "GIT_CLONE_COMMIT_COMMITER_NAME: ${GIT_CLONE_COMMIT_COMMITER_NAME}"
echo "GIT_CLONE_COMMIT_COMMITER_EMAIL: ${GIT_CLONE_COMMIT_COMMITER_EMAIL}"
echo "GIT_CLONE_COMMIT_COMMITTER_NAME: ${GIT_CLONE_COMMIT_COMMITTER_NAME}"
echo "GIT_CLONE_COMMIT_COMMITTER_EMAIL: ${GIT_CLONE_COMMIT_COMMITTER_EMAIL}"

_setup:
steps:
Expand Down Expand Up @@ -579,8 +579,8 @@ workflows:
envman unset --key GIT_CLONE_COMMIT_COUNT
envman unset --key GIT_CLONE_COMMIT_AUTHOR_NAME
envman unset --key GIT_CLONE_COMMIT_AUTHOR_EMAIL
envman unset --key GIT_CLONE_COMMIT_COMMITER_NAME
envman unset --key GIT_CLONE_COMMIT_COMMITER_EMAIL
envman unset --key GIT_CLONE_COMMIT_COMMITTER_NAME
envman unset --key GIT_CLONE_COMMIT_COMMITTER_EMAIL

_run:
steps:
Expand Down
4 changes: 2 additions & 2 deletions gitclone/output.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,8 +10,8 @@ import (
"github.com/bitrise-io/go-utils/v2/command"
)

const outputCommitterName = "GIT_CLONE_COMMIT_COMMITER_NAME"
const outputCommitterEmail = "GIT_CLONE_COMMIT_COMMITER_EMAIL"
const outputCommitterName = "GIT_CLONE_COMMIT_COMMITTER_NAME"
const outputCommitterEmail = "GIT_CLONE_COMMIT_COMMITTER_EMAIL"
const outputCommitCount = "GIT_CLONE_COMMIT_COUNT"

type gitOutput struct {
Expand Down
4 changes: 2 additions & 2 deletions gitclone/output_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,11 +49,11 @@ func Test_gitOutputs(t *testing.T) {
gitCmd: gitCmd.Log("%b", "ref/tags/1.0.0"),
},
{
envKey: "GIT_CLONE_COMMIT_COMMITER_NAME",
envKey: "GIT_CLONE_COMMIT_COMMITTER_NAME",
gitCmd: gitCmd.Log("%cn", "ref/tags/1.0.0"),
},
{
envKey: "GIT_CLONE_COMMIT_COMMITER_EMAIL",
envKey: "GIT_CLONE_COMMIT_COMMITTER_EMAIL",
gitCmd: gitCmd.Log("%ce", "ref/tags/1.0.0"),
},
{
Expand Down
4 changes: 2 additions & 2 deletions step.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -233,11 +233,11 @@ outputs:
opts:
title: Commit author email
description: Email of the checked-out commit.
- GIT_CLONE_COMMIT_COMMITER_NAME:
- GIT_CLONE_COMMIT_COMMITTER_NAME:
opts:
title: Committer name
description: Committer name of the checked-out commit.
- GIT_CLONE_COMMIT_COMMITER_EMAIL:
- GIT_CLONE_COMMIT_COMMITTER_EMAIL:
opts:
title: Committer email
description: Email of the checked-out commit.