Replace incorrect spelling of COMMITER with COMMITTER #192
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ofalvai What do you think of this change? I figure as long as we're doing a breaking change anyway, it couldn't hurt to fix this typo in the environment variable. |
hisaac
commented
Dec 14, 2022
Comment on lines
+78
to
+87
| | Environment Variable | Description | | ||
| |------------------------------------|------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------| | ||
| | `GIT_CLONE_COMMIT_HASH` | SHA hash of the checked-out commit. | | ||
| | `GIT_CLONE_COMMIT_MESSAGE_SUBJECT` | Commit message of the checked-out commit. | | ||
| | `GIT_CLONE_COMMIT_MESSAGE_BODY` | Commit message body of the checked-out commit. | | ||
| | `GIT_CLONE_COMMIT_COUNT` | Commit count after checkout. Count will only work properly if no `--depth` option is set. If `--depth` is set then the history truncated to the specified number of commits. Count will **not** fail but will be the clone depth. | | ||
| | `GIT_CLONE_COMMIT_AUTHOR_NAME` | Author of the checked-out commit. | | ||
| | `GIT_CLONE_COMMIT_AUTHOR_EMAIL` | Email of the checked-out commit. | | ||
| | `GIT_CLONE_COMMIT_COMMITTER_NAME` | Committer name of the checked-out commit. | | ||
| | `GIT_CLONE_COMMIT_COMMITTER_EMAIL` | Email of the checked-out commit. | |
There was a problem hiding this comment.
All these extra spaces are courtesy of GoLand, which added them automatically to normalize the Markdown table.
ofalvai
approved these changes
Dec 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
step.ymlandREADME.mdis updated with the changes (if needed)Version
Version update will occur when
nextis merged in at the end.Context
I noticed that we had 2 environment variables with a typo in them. This fixes that.
Changes
GIT_CLONE_COMMIT_COMMITER_NAMEwithGIT_CLONE_COMMIT_COMMITTER_NAMEGIT_CLONE_COMMIT_COMMITER_EMAILwithGIT_CLONE_COMMIT_COMMITTER_EMAIL