Skip to content

[bitnami/minio]: Templating sleep sleep time so that it can be passed using values.yaml #30718

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 19 commits into from
Dec 13, 2024
Merged
2 changes: 1 addition & 1 deletion bitnami/minio/Chart.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -34,4 +34,4 @@ maintainers:
name: minio
sources:
- https://github.com/bitnami/charts/tree/main/bitnami/minio
version: 14.8.5
version: 14.8.6
3 changes: 2 additions & 1 deletion bitnami/minio/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -352,6 +352,7 @@ You can enable this initContainer by setting `volumePermissions.enabled` to `tru
| `provisioning.networkPolicy.allowExternalEgress` | Allow the pod to access any range of port and all destinations. | `true` |
| `provisioning.networkPolicy.extraIngress` | Add extra ingress rules to the NetworkPolicy | `[]` |
| `provisioning.networkPolicy.extraEgress` | Add extra ingress rules to the NetworkPolicy | `[]` |
| `provisioning.sleepTime` | Provisioning Job sleep time | `5` |
| `automountServiceAccountToken` | Mount Service Account token in pod | `false` |
| `hostAliases` | MinIO® pod host aliases | `[]` |
| `containerPorts.api` | MinIO® container port to open for MinIO® API | `9000` |
Expand Down Expand Up @@ -656,4 +657,4 @@ Unless required by applicable law or agreed to in writing, software
distributed under the License is distributed on an "AS IS" BASIS,
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
See the License for the specific language governing permissions and
limitations under the License.
limitations under the License.
4 changes: 2 additions & 2 deletions bitnami/minio/templates/provisioning-job.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -143,10 +143,10 @@ spec:

mc admin service restart {{ $minioAlias }} --wait --json;

# Adding a sleep to ensure that the check below does not cause
# Adding a sleep and templating it to ensure that the check below does not cause
# a race condition. We check for the MinIO port because the
# "mc admin service restart --wait" command is not working as expected
sleep 5;
sleep {{ .Values.provisioning.sleepTime | default 5 }};
echo "Waiting for Minio to be available after restart";
wait-for-port \
--host={{ include "common.names.fullname" . }} \
Expand Down
Loading