Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bitnami/minio]: Templating sleep sleep time so that it can be passed using values.yaml #30718

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

choudham
Copy link

@choudham choudham commented Dec 2, 2024

Description of the change

This templates the sleep time for minio-provisioning job keeping the default at 5 sec.

Benefits

Easy to change using values.yaml

Applicable issues

(#30597)

Additional information

Checklist

Issue opened for this
(https://github.com/bitnami/charts/blob/main/CONTRIBUTING.md#sign-your-work)

Templating sleep time so that it can be passed using values.yaml

Signed-off-by: choudham <[email protected]>
Bumping Chart.yaml

Signed-off-by: choudham <[email protected]>
Signed-off-by: choudham <[email protected]>
Signed-off-by: Bitnami Containers <[email protected]>
@javsalgar javsalgar added verify Execute verification workflow for these changes in-progress labels Dec 3, 2024
@github-actions github-actions bot removed the triage Triage is needed label Dec 3, 2024
@github-actions github-actions bot removed the request for review from javsalgar December 3, 2024 09:17
Signed-off-by: Bitnami Containers <[email protected]>
Copy link
Member

@dgomezleon dgomezleon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for contributing.

I would suggest adding the new parameter to values.yaml. Otherwise, the README.md will be overwritten in a future PR and the note will be lost. Also, since it adds a new parameter, use version 14.9.0 instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in-progress minio verify Execute verification workflow for these changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants