-
Notifications
You must be signed in to change notification settings - Fork 9.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[bitnami/kibana] set base host to 0.0.0.0 #30023
[bitnami/kibana] set base host to 0.0.0.0 #30023
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for taking the time to contribute to this project. Please take a look at my comments
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please take a look at the minor suggestion I added and fix the DCO issue
* [bitnami/flux] Release 2.3.20 updating components versions Signed-off-by: Bitnami Containers <[email protected]> * Update CHANGELOG.md Signed-off-by: Bitnami Containers <[email protected]> * Update CRDs automatically Signed-off-by: Bitnami Containers <[email protected]> --------- Signed-off-by: Bitnami Containers <[email protected]> Signed-off-by: Michael Faherty <[email protected]>
* [bitnami/external-dns] Release 8.3.9 updating components versions Signed-off-by: Bitnami Containers <[email protected]> * Update CHANGELOG.md Signed-off-by: Bitnami Containers <[email protected]> --------- Signed-off-by: Bitnami Containers <[email protected]> Signed-off-by: Michael Faherty <[email protected]>
* [bitnami/gitea] Release 2.3.23 updating components versions Signed-off-by: Bitnami Containers <[email protected]> * Update CHANGELOG.md Signed-off-by: Bitnami Containers <[email protected]> --------- Signed-off-by: Bitnami Containers <[email protected]> Signed-off-by: Michael Faherty <[email protected]>
* [bitnami/grafana-loki] Release 4.6.18 updating components versions Signed-off-by: Bitnami Containers <[email protected]> * Update CHANGELOG.md Signed-off-by: Bitnami Containers <[email protected]> --------- Signed-off-by: Bitnami Containers <[email protected]> Signed-off-by: Michael Faherty <[email protected]>
* [bitnami/grafana-operator] Release 4.7.1 updating components versions Signed-off-by: Bitnami Containers <[email protected]> * Update CHANGELOG.md Signed-off-by: Bitnami Containers <[email protected]> --------- Signed-off-by: Bitnami Containers <[email protected]> Signed-off-by: Michael Faherty <[email protected]>
* [bitnami/haproxy] Release 2.1.7 updating components versions Signed-off-by: Bitnami Containers <[email protected]> * Update CHANGELOG.md Signed-off-by: Bitnami Containers <[email protected]> --------- Signed-off-by: Bitnami Containers <[email protected]> Signed-off-by: Michael Faherty <[email protected]>
* [bitnami/grafana-tempo] Release 3.7.11 updating components versions Signed-off-by: Bitnami Containers <[email protected]> * Update CHANGELOG.md Signed-off-by: Bitnami Containers <[email protected]> --------- Signed-off-by: Bitnami Containers <[email protected]> Signed-off-by: Michael Faherty <[email protected]>
* [bitnami/grafana] Release 11.3.22 updating components versions Signed-off-by: Bitnami Containers <[email protected]> * Update CHANGELOG.md Signed-off-by: Bitnami Containers <[email protected]> --------- Signed-off-by: Bitnami Containers <[email protected]> Signed-off-by: Michael Faherty <[email protected]>
* [bitnami/grafana-mimir] Release 1.2.18 updating components versions Signed-off-by: Bitnami Containers <[email protected]> * Update CHANGELOG.md Signed-off-by: Bitnami Containers <[email protected]> --------- Signed-off-by: Bitnami Containers <[email protected]> Signed-off-by: Michael Faherty <[email protected]>
* [bitnami/influxdb] Release 6.3.21 updating components versions Signed-off-by: Bitnami Containers <[email protected]> * Update CHANGELOG.md Signed-off-by: Bitnami Containers <[email protected]> --------- Signed-off-by: Bitnami Containers <[email protected]> Signed-off-by: Michael Faherty <[email protected]>
* [bitnami/kiam] Release 2.2.15 updating components versions Signed-off-by: Bitnami Containers <[email protected]> * Update CHANGELOG.md Signed-off-by: Bitnami Containers <[email protected]> --------- Signed-off-by: Bitnami Containers <[email protected]> Signed-off-by: Michael Faherty <[email protected]>
* [bitnami/jaeger] Release 3.0.2 updating components versions Signed-off-by: Bitnami Containers <[email protected]> * Update CHANGELOG.md Signed-off-by: Bitnami Containers <[email protected]> --------- Signed-off-by: Bitnami Containers <[email protected]> Signed-off-by: Michael Faherty <[email protected]>
* [bitnami/kube-state-metrics] Release 4.2.14 updating components versions Signed-off-by: Bitnami Containers <[email protected]> * Update CHANGELOG.md Signed-off-by: Bitnami Containers <[email protected]> --------- Signed-off-by: Bitnami Containers <[email protected]> Signed-off-by: Michael Faherty <[email protected]>
* [bitnami/kubernetes-event-exporter] Release 3.2.13 updating components versions Signed-off-by: Bitnami Containers <[email protected]> * Update CHANGELOG.md Signed-off-by: Bitnami Containers <[email protected]> --------- Signed-off-by: Bitnami Containers <[email protected]> Signed-off-by: Michael Faherty <[email protected]>
* [bitnami/kuberay] Release 1.2.18 updating components versions Signed-off-by: Bitnami Containers <[email protected]> * Update CHANGELOG.md Signed-off-by: Bitnami Containers <[email protected]> --------- Signed-off-by: Bitnami Containers <[email protected]> Signed-off-by: Michael Faherty <[email protected]>
* [bitnami/metallb] Release 6.3.13 updating components versions Signed-off-by: Bitnami Containers <[email protected]> * Update CHANGELOG.md Signed-off-by: Bitnami Containers <[email protected]> --------- Signed-off-by: Bitnami Containers <[email protected]> Signed-off-by: Michael Faherty <[email protected]>
* [bitnami/metrics-server] Release 7.2.15 updating components versions Signed-off-by: Bitnami Containers <[email protected]> * Update CHANGELOG.md Signed-off-by: Bitnami Containers <[email protected]> --------- Signed-off-by: Bitnami Containers <[email protected]> Signed-off-by: Michael Faherty <[email protected]>
* [bitnami/solr] Release 9.4.6 updating components versions Signed-off-by: Bitnami Containers <[email protected]> * Update CHANGELOG.md Signed-off-by: Bitnami Containers <[email protected]> --------- Signed-off-by: Bitnami Containers <[email protected]> Signed-off-by: Michael Faherty <[email protected]>
* [bitnami/postgresql-ha] Release 14.3.2 updating components versions Signed-off-by: Bitnami Containers <[email protected]> * Update CHANGELOG.md Signed-off-by: Bitnami Containers <[email protected]> --------- Signed-off-by: Bitnami Containers <[email protected]> Signed-off-by: Michael Faherty <[email protected]>
* [bitnami/memcached] Release 7.5.2 updating components versions Signed-off-by: Bitnami Containers <[email protected]> * Update CHANGELOG.md Signed-off-by: Bitnami Containers <[email protected]> --------- Signed-off-by: Bitnami Containers <[email protected]> Signed-off-by: Michael Faherty <[email protected]>
* [bitnami/harbor] Release 24.0.1 updating components versions Signed-off-by: Bitnami Containers <[email protected]> * Update CHANGELOG.md Signed-off-by: Bitnami Containers <[email protected]> --------- Signed-off-by: Bitnami Containers <[email protected]> Signed-off-by: Michael Faherty <[email protected]>
Signed-off-by: Michael Faherty <[email protected]>
…mplate (bitnami#29963) Signed-off-by: Léo Colombaro <[email protected]> Signed-off-by: Michael Faherty <[email protected]>
Signed-off-by: Michael Faherty <[email protected]>
* [bitnami/postgresql] Release 16.0.4 updating components versions Signed-off-by: Bitnami Containers <[email protected]> * Update CHANGELOG.md Signed-off-by: Bitnami Containers <[email protected]> --------- Signed-off-by: Bitnami Containers <[email protected]> Signed-off-by: Michael Faherty <[email protected]>
* [bitnami/apisix] Release 3.5.2 updating components versions Signed-off-by: Bitnami Containers <[email protected]> * Update CHANGELOG.md Signed-off-by: Bitnami Containers <[email protected]> * Update CRDs automatically Signed-off-by: Bitnami Containers <[email protected]> --------- Signed-off-by: Bitnami Containers <[email protected]> Signed-off-by: Michael Faherty <[email protected]>
* [bitnami/nginx] Release 18.2.4 updating components versions Signed-off-by: Bitnami Containers <[email protected]> * Update CHANGELOG.md Signed-off-by: Bitnami Containers <[email protected]> --------- Signed-off-by: Bitnami Containers <[email protected]> Signed-off-by: Michael Faherty <[email protected]>
* [bitnami/grafana-mimir] Release 1.2.19 updating components versions Signed-off-by: Bitnami Containers <[email protected]> * Update CHANGELOG.md Signed-off-by: Bitnami Containers <[email protected]> --------- Signed-off-by: Bitnami Containers <[email protected]> Signed-off-by: Michael Faherty <[email protected]>
* [bitnami/mastodon] Release 9.0.1 updating components versions Signed-off-by: Bitnami Containers <[email protected]> * Update CHANGELOG.md Signed-off-by: Bitnami Containers <[email protected]> --------- Signed-off-by: Bitnami Containers <[email protected]> Signed-off-by: Michael Faherty <[email protected]>
bitnami#29993) Signed-off-by: Michael Faherty <[email protected]>
…ation (bitnami#30022) Signed-off-by: Michael Faherty <[email protected]>
Signed-off-by: Michael Faherty <[email protected]>
Signed-off-by: Michael Faherty <[email protected]>
Signed-off-by: Bitnami Containers <[email protected]> Signed-off-by: Michael Faherty <[email protected]>
Signed-off-by: Bitnami Containers <[email protected]> Signed-off-by: Michael Faherty <[email protected]>
Co-authored-by: Juan José Martos <[email protected]> Signed-off-by: Michael Faherty <[email protected]>
Signed-off-by: Bitnami Containers <[email protected]> Signed-off-by: Michael Faherty <[email protected]>
Co-authored-by: Juan José Martos <[email protected]> Signed-off-by: Michael Faherty <[email protected]>
Signed-off-by: Bitnami Containers <[email protected]> Signed-off-by: Michael Faherty <[email protected]>
591f2ae
to
546e21b
Compare
@jotamartos I'll bring these changes into a new PR / branch in a few days as my re-base here got a bit messy trying to fix the DCO issue. |
Closing in favor of #30131 |
Description of the change
This change defaults the host value to 0.0.0.0 instead of
::
in the configmap because unless folks have ipv6 enabled, :: causes Kibana to fail on startup.Benefits
The majority of the world is using IPV4 and this is a more sane default. If needed, folks can update for ipv6 compatability manually.
Possible drawbacks
If you're using ipv6 without any ipv4 fallback, this change may be breaking (unlikely scenario)
Applicable issues
Additional information
Checklist
Chart.yaml
according to semver. This is not necessary when the changes only affect README.md files.README.md
using readme-generator-for-helm