Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[bitnami/kibana] set base host to 0.0.0.0 #30023

Closed
wants to merge 616 commits into from
Closed

[bitnami/kibana] set base host to 0.0.0.0 #30023

wants to merge 616 commits into from

Conversation

mike12806
Copy link
Contributor

@mike12806 mike12806 commented Oct 21, 2024 •
edited
Loading

Description of the change

This change defaults the host value to 0.0.0.0 instead of :: in the configmap because unless folks have ipv6 enabled, :: causes Kibana to fail on startup.

Benefits

The majority of the world is using IPV4 and this is a more sane default. If needed, folks can update for ipv6 compatability manually.

Possible drawbacks

If you're using ipv6 without any ipv4 fallback, this change may be breaking (unlikely scenario)

Applicable issues

Additional information

Checklist

  • Chart version bumped in Chart.yaml according to semver. This is not necessary when the changes only affect README.md files.
  • Variables are documented in the values.yaml and added to the README.md using readme-generator-for-helm
  • Title of the pull request follows this pattern [bitnami/<name_of_the_chart>] Descriptive title
  • All commits signed off and in agreement of Developer Certificate of Origin (DCO)

@github-actions github-actions bot added kibana triage Triage is needed labels Oct 21, 2024
@javsalgar javsalgar added verify Execute verification workflow for these changes in-progress labels Oct 22, 2024
@github-actions github-actions bot removed the triage Triage is needed label Oct 22, 2024
@github-actions github-actions bot removed the request for review from javsalgar October 22, 2024 07:55
jotamartos
jotamartos requested changes Oct 28, 2024
View reviewed changes
Copy link
Contributor

@jotamartos jotamartos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for taking the time to contribute to this project. Please take a look at my comments

bitnami/kibana/templates/configmap.yaml Outdated Show resolved Hide resolved
bitnami/kibana/Chart.yaml Outdated Show resolved Hide resolved
jotamartos
jotamartos requested changes Oct 29, 2024
View reviewed changes
Copy link
Contributor

@jotamartos jotamartos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please take a look at the minor suggestion I added and fix the DCO issue

bitnami/kibana/templates/configmap.yaml Outdated Show resolved Hide resolved
@bitnami-bot @mike12806
[bitnami/flux] Release 2.3.20 (bitnami#29691)
cdcb5ec 
* [bitnami/flux] Release 2.3.20 updating components versions

Signed-off-by: Bitnami Containers <[email protected]>

* Update CHANGELOG.md

Signed-off-by: Bitnami Containers <[email protected]>

* Update CRDs automatically

Signed-off-by: Bitnami Containers <[email protected]>

---------

Signed-off-by: Bitnami Containers <[email protected]>
Signed-off-by: Michael Faherty <[email protected]>
@bitnami-bot @mike12806
[bitnami/external-dns] Release 8.3.9 (bitnami#29690)
ac2463d 
* [bitnami/external-dns] Release 8.3.9 updating components versions

Signed-off-by: Bitnami Containers <[email protected]>

* Update CHANGELOG.md

Signed-off-by: Bitnami Containers <[email protected]>

---------

Signed-off-by: Bitnami Containers <[email protected]>
Signed-off-by: Michael Faherty <[email protected]>
@bitnami-bot @mike12806
[bitnami/gitea] Release 2.3.23 (bitnami#29692)
59711dc 
* [bitnami/gitea] Release 2.3.23 updating components versions

Signed-off-by: Bitnami Containers <[email protected]>

* Update CHANGELOG.md

Signed-off-by: Bitnami Containers <[email protected]>

---------

Signed-off-by: Bitnami Containers <[email protected]>
Signed-off-by: Michael Faherty <[email protected]>
@bitnami-bot @mike12806
[bitnami/grafana-loki] Release 4.6.18 (bitnami#29695)
441c38b 
* [bitnami/grafana-loki] Release 4.6.18 updating components versions

Signed-off-by: Bitnami Containers <[email protected]>

* Update CHANGELOG.md

Signed-off-by: Bitnami Containers <[email protected]>

---------

Signed-off-by: Bitnami Containers <[email protected]>
Signed-off-by: Michael Faherty <[email protected]>
@bitnami-bot @mike12806
[bitnami/grafana-operator] Release 4.7.1 (bitnami#29694)
a8bfcb0 
* [bitnami/grafana-operator] Release 4.7.1 updating components versions

Signed-off-by: Bitnami Containers <[email protected]>

* Update CHANGELOG.md

Signed-off-by: Bitnami Containers <[email protected]>

---------

Signed-off-by: Bitnami Containers <[email protected]>
Signed-off-by: Michael Faherty <[email protected]>
@bitnami-bot @mike12806
[bitnami/haproxy] Release 2.1.7 (bitnami#29698)
e6be446 
* [bitnami/haproxy] Release 2.1.7 updating components versions

Signed-off-by: Bitnami Containers <[email protected]>

* Update CHANGELOG.md

Signed-off-by: Bitnami Containers <[email protected]>

---------

Signed-off-by: Bitnami Containers <[email protected]>
Signed-off-by: Michael Faherty <[email protected]>
@bitnami-bot @mike12806
[bitnami/grafana-tempo] Release 3.7.11 (bitnami#29696)
382333c 
* [bitnami/grafana-tempo] Release 3.7.11 updating components versions

Signed-off-by: Bitnami Containers <[email protected]>

* Update CHANGELOG.md

Signed-off-by: Bitnami Containers <[email protected]>

---------

Signed-off-by: Bitnami Containers <[email protected]>
Signed-off-by: Michael Faherty <[email protected]>
@bitnami-bot @mike12806
[bitnami/grafana] Release 11.3.22 (bitnami#29697)
41b018c 
* [bitnami/grafana] Release 11.3.22 updating components versions

Signed-off-by: Bitnami Containers <[email protected]>

* Update CHANGELOG.md

Signed-off-by: Bitnami Containers <[email protected]>

---------

Signed-off-by: Bitnami Containers <[email protected]>
Signed-off-by: Michael Faherty <[email protected]>
@bitnami-bot @mike12806
[bitnami/grafana-mimir] Release 1.2.18 (bitnami#29693)
c19309a 
* [bitnami/grafana-mimir] Release 1.2.18 updating components versions

Signed-off-by: Bitnami Containers <[email protected]>

* Update CHANGELOG.md

Signed-off-by: Bitnami Containers <[email protected]>

---------

Signed-off-by: Bitnami Containers <[email protected]>
Signed-off-by: Michael Faherty <[email protected]>
@bitnami-bot @mike12806
[bitnami/influxdb] Release 6.3.21 (bitnami#29699)
004ed0d 
* [bitnami/influxdb] Release 6.3.21 updating components versions

Signed-off-by: Bitnami Containers <[email protected]>

* Update CHANGELOG.md

Signed-off-by: Bitnami Containers <[email protected]>

---------

Signed-off-by: Bitnami Containers <[email protected]>
Signed-off-by: Michael Faherty <[email protected]>
@bitnami-bot @mike12806
[bitnami/kiam] Release 2.2.15 (bitnami#29701)
d02127e 
* [bitnami/kiam] Release 2.2.15 updating components versions

Signed-off-by: Bitnami Containers <[email protected]>

* Update CHANGELOG.md

Signed-off-by: Bitnami Containers <[email protected]>

---------

Signed-off-by: Bitnami Containers <[email protected]>
Signed-off-by: Michael Faherty <[email protected]>
@bitnami-bot @mike12806
[bitnami/jaeger] Release 3.0.2 (bitnami#29700)
413fc8f 
* [bitnami/jaeger] Release 3.0.2 updating components versions

Signed-off-by: Bitnami Containers <[email protected]>

* Update CHANGELOG.md

Signed-off-by: Bitnami Containers <[email protected]>

---------

Signed-off-by: Bitnami Containers <[email protected]>
Signed-off-by: Michael Faherty <[email protected]>
@bitnami-bot @mike12806
[bitnami/kube-state-metrics] Release 4.2.14 (bitnami#29702)
abc4517 
* [bitnami/kube-state-metrics] Release 4.2.14 updating components versions

Signed-off-by: Bitnami Containers <[email protected]>

* Update CHANGELOG.md

Signed-off-by: Bitnami Containers <[email protected]>

---------

Signed-off-by: Bitnami Containers <[email protected]>
Signed-off-by: Michael Faherty <[email protected]>
@bitnami-bot @mike12806
[bitnami/kubernetes-event-exporter] Release 3.2.13 (bitnami#29704)
35c440e 
* [bitnami/kubernetes-event-exporter] Release 3.2.13 updating components versions

Signed-off-by: Bitnami Containers <[email protected]>

* Update CHANGELOG.md

Signed-off-by: Bitnami Containers <[email protected]>

---------

Signed-off-by: Bitnami Containers <[email protected]>
Signed-off-by: Michael Faherty <[email protected]>
@bitnami-bot @mike12806
[bitnami/kuberay] Release 1.2.18 (bitnami#29703)
a4c6f80 
* [bitnami/kuberay] Release 1.2.18 updating components versions

Signed-off-by: Bitnami Containers <[email protected]>

* Update CHANGELOG.md

Signed-off-by: Bitnami Containers <[email protected]>

---------

Signed-off-by: Bitnami Containers <[email protected]>
Signed-off-by: Michael Faherty <[email protected]>
@bitnami-bot @mike12806
[bitnami/metallb] Release 6.3.13 (bitnami#29706)
963d1ea 
* [bitnami/metallb] Release 6.3.13 updating components versions

Signed-off-by: Bitnami Containers <[email protected]>

* Update CHANGELOG.md

Signed-off-by: Bitnami Containers <[email protected]>

---------

Signed-off-by: Bitnami Containers <[email protected]>
Signed-off-by: Michael Faherty <[email protected]>
@bitnami-bot @mike12806
[bitnami/metrics-server] Release 7.2.15 (bitnami#29705)
be5d8bd 
* [bitnami/metrics-server] Release 7.2.15 updating components versions

Signed-off-by: Bitnami Containers <[email protected]>

* Update CHANGELOG.md

Signed-off-by: Bitnami Containers <[email protected]>

---------

Signed-off-by: Bitnami Containers <[email protected]>
Signed-off-by: Michael Faherty <[email protected]>
bitnami-bot and others added 22 commits October 29, 2024 21:55
@bitnami-bot @mike12806
[bitnami/solr] Release 9.4.6 (bitnami#30001)
711e4c6 
* [bitnami/solr] Release 9.4.6 updating components versions

Signed-off-by: Bitnami Containers <[email protected]>

* Update CHANGELOG.md

Signed-off-by: Bitnami Containers <[email protected]>

---------

Signed-off-by: Bitnami Containers <[email protected]>
Signed-off-by: Michael Faherty <[email protected]>
@bitnami-bot @mike12806
[bitnami/postgresql-ha] Release 14.3.2 (bitnami#30002)
0b3c2a4 
* [bitnami/postgresql-ha] Release 14.3.2 updating components versions

Signed-off-by: Bitnami Containers <[email protected]>

* Update CHANGELOG.md

Signed-off-by: Bitnami Containers <[email protected]>

---------

Signed-off-by: Bitnami Containers <[email protected]>
Signed-off-by: Michael Faherty <[email protected]>
@bitnami-bot @mike12806
[bitnami/memcached] Release 7.5.2 (bitnami#30004)
4629c9c 
* [bitnami/memcached] Release 7.5.2 updating components versions

Signed-off-by: Bitnami Containers <[email protected]>

* Update CHANGELOG.md

Signed-off-by: Bitnami Containers <[email protected]>

---------

Signed-off-by: Bitnami Containers <[email protected]>
Signed-off-by: Michael Faherty <[email protected]>
@bitnami-bot @mike12806
[bitnami/harbor] Release 24.0.1 (bitnami#30007)
e83c881 
* [bitnami/harbor] Release 24.0.1 updating components versions

Signed-off-by: Bitnami Containers <[email protected]>

* Update CHANGELOG.md

Signed-off-by: Bitnami Containers <[email protected]>

---------

Signed-off-by: Bitnami Containers <[email protected]>
Signed-off-by: Michael Faherty <[email protected]>
@juan131 @mike12806
[bitnami/deepspeed] Improve Goss tests reliability (bitnami#30008)
ae670ce 
Signed-off-by: Michael Faherty <[email protected]>
@LeoColomb @mike12806
[bitnami/template] Use common password manager for password secret te…
de105e4 
…mplate (bitnami#29963)

Signed-off-by: Léo Colombaro <[email protected]>
Signed-off-by: Michael Faherty <[email protected]>
@uubk @mike12806
[bitnami/contour]: Fix invalid volume indentation (bitnami#29890)
1ce39b8 
Signed-off-by: Michael Faherty <[email protected]>
@bitnami-bot @mike12806
[bitnami/postgresql] Release 16.0.4 (bitnami#30013)
6b46821 
* [bitnami/postgresql] Release 16.0.4 updating components versions

Signed-off-by: Bitnami Containers <[email protected]>

* Update CHANGELOG.md

Signed-off-by: Bitnami Containers <[email protected]>

---------

Signed-off-by: Bitnami Containers <[email protected]>
Signed-off-by: Michael Faherty <[email protected]>
@bitnami-bot @mike12806
[bitnami/apisix] Release 3.5.2 (bitnami#30014)
810ae8e 
* [bitnami/apisix] Release 3.5.2 updating components versions

Signed-off-by: Bitnami Containers <[email protected]>

* Update CHANGELOG.md

Signed-off-by: Bitnami Containers <[email protected]>

* Update CRDs automatically

Signed-off-by: Bitnami Containers <[email protected]>

---------

Signed-off-by: Bitnami Containers <[email protected]>
Signed-off-by: Michael Faherty <[email protected]>
@bitnami-bot @mike12806
[bitnami/nginx] Release 18.2.4 (bitnami#30017)
947ff7f 
* [bitnami/nginx] Release 18.2.4 updating components versions

Signed-off-by: Bitnami Containers <[email protected]>

* Update CHANGELOG.md

Signed-off-by: Bitnami Containers <[email protected]>

---------

Signed-off-by: Bitnami Containers <[email protected]>
Signed-off-by: Michael Faherty <[email protected]>
@bitnami-bot @mike12806
[bitnami/grafana-mimir] Release 1.2.19 (bitnami#30018)
6e168b3 
* [bitnami/grafana-mimir] Release 1.2.19 updating components versions

Signed-off-by: Bitnami Containers <[email protected]>

* Update CHANGELOG.md

Signed-off-by: Bitnami Containers <[email protected]>

---------

Signed-off-by: Bitnami Containers <[email protected]>
Signed-off-by: Michael Faherty <[email protected]>
@bitnami-bot @mike12806
[bitnami/mastodon] Release 9.0.1 (bitnami#30019)
1dbbf75 
* [bitnami/mastodon] Release 9.0.1 updating components versions

Signed-off-by: Bitnami Containers <[email protected]>

* Update CHANGELOG.md

Signed-off-by: Bitnami Containers <[email protected]>

---------

Signed-off-by: Bitnami Containers <[email protected]>
Signed-off-by: Michael Faherty <[email protected]>
@Zakhar-Petrov @mike12806
[bitnami/nginx-ingress-controller] Add TCP/UDP ports name prefix param (
19e3b9b 
bitnami#29993)

Signed-off-by: Michael Faherty <[email protected]>
@juan131 @mike12806
[bitnami/discourse] Avoid looping on subdirectories on plugins instal…
4ade9d9 
…ation (bitnami#30022)

Signed-off-by: Michael Faherty <[email protected]>
@mike12806
version bump
401aa1e 
Signed-off-by: Michael Faherty <[email protected]>
@mike12806
feat: pull in config value from values.yaml
cbe6e41 
Signed-off-by: Michael Faherty <[email protected]>
@bitnami-bot @mike12806
Update CHANGELOG.md
dd90fe2 
Signed-off-by: Bitnami Containers <[email protected]>
Signed-off-by: Michael Faherty <[email protected]>
@bitnami-bot @mike12806
Update CHANGELOG.md
3321603 
Signed-off-by: Bitnami Containers <[email protected]>
Signed-off-by: Michael Faherty <[email protected]>
@mike12806 @jotamartos
chore: minor version bump
e1fd8d9 
Co-authored-by: Juan José Martos <[email protected]>
Signed-off-by: Michael Faherty <[email protected]>
@bitnami-bot @mike12806
Update CHANGELOG.md
0ef3632 
Signed-off-by: Bitnami Containers <[email protected]>
Signed-off-by: Michael Faherty <[email protected]>
@mike12806 @jotamartos
Update bitnami/kibana/templates/configmap.yaml
3f59dce 
Co-authored-by: Juan José Martos <[email protected]>
Signed-off-by: Michael Faherty <[email protected]>
@bitnami-bot @mike12806
Update CHANGELOG.md
546e21b 
Signed-off-by: Bitnami Containers <[email protected]>
Signed-off-by: Michael Faherty <[email protected]>
@mike12806 mike12806 force-pushed the chore/set-base-host-to-0.0.0.0 branch from 591f2ae to 546e21b Compare October 30, 2024 01:56
@mike12806
Copy link
Contributor Author

@jotamartos I'll bring these changes into a new PR / branch in a few days as my re-base here got a bit messy trying to fix the DCO issue.

@mike12806
Copy link
Contributor Author

Closing in favor of #30131

@mike12806 mike12806 closed this Oct 30, 2024
@mike12806 mike12806 deleted the chore/set-base-host-to-0.0.0.0 branch October 30, 2024 02:09
@mike12806 mike12806 mentioned this pull request Oct 30, 2024
Open
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jotamartos jotamartos jotamartos requested changes

Assignees

@jotamartos jotamartos

Labels
kibana solved verify Execute verification workflow for these changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[bitnami/kibana] [FATAL][root] Error: listen EAFNOSUPPORT: address family not supported :::5601