Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bitnami/template] Use common password manager for password secret template #29963

Merged
merged 1 commit into from
Oct 21, 2024

Conversation

LeoColomb
Copy link
Contributor

Description of the change

Use common.secrets.passwords.manage right from the template to streamline future charts on how they handle password.

Benefits

As this is on the template, this is purely a suggestion.

Possible drawbacks

Applicable issues

Additional information

Checklist

@github-actions github-actions bot added the triage Triage is needed label Oct 17, 2024
@carrodher carrodher added verify Execute verification workflow for these changes in-progress labels Oct 18, 2024
@github-actions github-actions bot removed the triage Triage is needed label Oct 18, 2024
@github-actions github-actions bot removed the request for review from javsalgar October 18, 2024 12:39
Copy link
Member

@dgomezleon dgomezleon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for contributing!

@dgomezleon dgomezleon merged commit c6d6b17 into bitnami:main Oct 21, 2024
32 checks passed
@LeoColomb LeoColomb deleted the feat/template-manager branch October 21, 2024 09:30
mike12806 pushed a commit to mike12806/charts that referenced this pull request Oct 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
solved verify Execute verification workflow for these changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants