-
Notifications
You must be signed in to change notification settings - Fork 9.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[bitnami/external-dns] Allow rfc2136-zone to specify multiple zones #28681
Conversation
Signed-off-by: JinXinWang <[email protected]>
Signed-off-by: JinXinWang <[email protected]>
Signed-off-by: Bitnami Containers <[email protected]>
Signed-off-by: opencmit2 <[email protected]>
Signed-off-by: Bitnami Containers <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @opencmit2 thanks a lot for your contribution.
It looks good but I have a little concern, because there is unnecessary complexity around this extraArgs
feature. Could you give it a glance and share your thoughts?
@fmulero I did what you said, but I didn't test it successfully and it's not clear if it's compatible with previous versions |
Signed-off-by: Fran Mulero <[email protected]>
Signed-off-by: Bitnami Containers <[email protected]>
This Pull Request has been automatically marked as "stale" because it has not had recent activity (for 15 days). It will be closed if no further activity occurs. Thank you for your contribution. |
Due to the lack of activity in the last 5 days since it was marked as "stale", we proceed to close this Pull Request. Do not hesitate to reopen it later if necessary. |
Pull request was closed
this PR would be useful to me |
Signed-off-by: Carlos Rodríguez Hernández <[email protected]>
Signed-off-by: Bitnami Containers <[email protected]>
Signed-off-by: Fran Mulero <[email protected]>
Signed-off-by: Bitnami Containers <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description of the change
This change allows specifying more than two rfc2136 zones in the values.yaml file, addressing the limitation where only two zones could be provided.
Benefits
Possible drawbacks
Applicable issues
Additional information
Checklist
Chart.yaml
according to semver. This is not necessary when the changes only affect README.md files.README.md
using readme-generator-for-helm