Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bitnami/external-dns] Allow rfc2136-zone to specify multiple zones #28681

Merged
merged 11 commits into from
Oct 29, 2024

Conversation

opencmit2
Copy link
Contributor

@opencmit2 opencmit2 commented Aug 6, 2024

Description of the change

  • Modified Helm template to handle single string or list values for extraArgs.

This change allows specifying more than two rfc2136 zones in the values.yaml file, addressing the limitation where only two zones could be provided.

Benefits

Possible drawbacks

Applicable issues

Additional information

Checklist

  • Chart version bumped in Chart.yaml according to semver. This is not necessary when the changes only affect README.md files.
  • Variables are documented in the values.yaml and added to the README.md using readme-generator-for-helm
  • Title of the pull request follows this pattern [bitnami/<name_of_the_chart>] Descriptive title
  • All commits signed off and in agreement of Developer Certificate of Origin (DCO)

@carrodher carrodher added verify Execute verification workflow for these changes in-progress labels Aug 6, 2024
@github-actions github-actions bot removed the triage Triage is needed label Aug 6, 2024
@github-actions github-actions bot removed the request for review from javsalgar August 6, 2024 07:37
@github-actions github-actions bot requested a review from fmulero August 6, 2024 07:37
opencmit2 and others added 2 commits August 7, 2024 17:29
Signed-off-by: opencmit2 <[email protected]>
Signed-off-by: Bitnami Containers <[email protected]>
Copy link
Collaborator

@fmulero fmulero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @opencmit2 thanks a lot for your contribution.

It looks good but I have a little concern, because there is unnecessary complexity around this extraArgs feature. Could you give it a glance and share your thoughts?

@opencmit2
Copy link
Contributor Author

@fmulero I did what you said, but I didn't test it successfully and it's not clear if it's compatible with previous versions

@opencmit2
Copy link
Contributor Author

image

fmulero
fmulero previously approved these changes Aug 23, 2024
fmulero
fmulero previously approved these changes Aug 23, 2024
Signed-off-by: Bitnami Containers <[email protected]>
Copy link

github-actions bot commented Sep 8, 2024

This Pull Request has been automatically marked as "stale" because it has not had recent activity (for 15 days). It will be closed if no further activity occurs. Thank you for your contribution.

@github-actions github-actions bot added the stale 15 days without activity label Sep 8, 2024
Copy link

Due to the lack of activity in the last 5 days since it was marked as "stale", we proceed to close this Pull Request. Do not hesitate to reopen it later if necessary.

@bitnami-bot bitnami-bot added stale 15 days without activity and removed stale 15 days without activity labels Sep 14, 2024
auto-merge was automatically disabled September 14, 2024 02:19

Pull request was closed

@TomyLobo
Copy link

this PR would be useful to me

@carrodher carrodher reopened this Oct 29, 2024
@github-actions github-actions bot added triage Triage is needed and removed solved labels Oct 29, 2024
Signed-off-by: Carlos Rodríguez Hernández <[email protected]>
@carrodher carrodher added in-progress and removed stale 15 days without activity triage Triage is needed labels Oct 29, 2024
@github-actions github-actions bot removed the request for review from carrodher October 29, 2024 06:59
@github-actions github-actions bot requested a review from fmulero October 29, 2024 07:00
bitnami-bot and others added 3 commits October 29, 2024 07:07
Signed-off-by: Bitnami Containers <[email protected]>
Signed-off-by: Bitnami Containers <[email protected]>
@fmulero fmulero enabled auto-merge (squash) October 29, 2024 10:34
Copy link
Collaborator

@fmulero fmulero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fmulero fmulero merged commit 0868c63 into bitnami:main Oct 29, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
external-dns solved verify Execute verification workflow for these changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[bitnami/external-dns] External dns rfc2136 zone cannot supply more than 2 zones.
6 participants