Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bitnami/external-dns] External dns rfc2136 zone cannot supply more than 2 zones. #28645

Closed
Jeremy-Boyle opened this issue Aug 2, 2024 · 5 comments · Fixed by #28681
Closed
Assignees
Labels
external-dns feature-request solved stale 15 days without activity triage Triage is needed

Comments

@Jeremy-Boyle
Copy link
Contributor

Jeremy-Boyle commented Aug 2, 2024

Name and Version

bitnami/external-dns 8.3.3

What is the problem this feature will solve?

Currently the helm template only allows for a single zone, however external-dns can support more than one zone by adding extra argument variables similar to how the domain filter works.

Currently the only way to add another zone is to add it with

extraArgs:
  rfc2136-zone: extra-zone.com

However since this is a map and not a array it would only be able to support one additional zone.

This will support more than one zone, however, due to the limitations there might be additional providers that allow multiple arguments that cannot be set due to how extraArgs works. Need feedback if this should be changed to how most other bitnami charts do it via. My recommendation is that this should be changed from a map to a array to be inline with other charts to reduce a dependency when arguments are added that support multiple flags.

extraArgs: []

This fix will change the value

rfc2136:
  zone: ""

to

rfc2136:
  zones: []

What is the feature you are proposing to solve the problem?

This will change the default values file to support more than two zones.

And discuss if changing to extraArgs: [] makes sense

What alternatives have you considered?

The following can work for another zone, another option is manually editing the template and maintaining yourself.

extraArgs:
  rfc2136-zone: extra-zone.com
@github-actions github-actions bot added the triage Triage is needed label Aug 2, 2024
@javsalgar javsalgar changed the title External dns rfc2136 zone cannot supply more than 2 zones. [bitnami/external-dns] External dns rfc2136 zone cannot supply more than 2 zones. Aug 5, 2024
@javsalgar
Copy link
Contributor

Hi,

I agree that using an array would make more sense to allow this kind of scenarios. I will forward it to the team but I cannot guarantee an ETA. Would you like to submit a PR adding support for extraArgs as an array? (without breaking backwards compatibility)

@javsalgar
Copy link
Contributor

Thank you so much for the PR!

Copy link

This Issue has been automatically marked as "stale" because it has not had recent activity (for 15 days). It will be closed if no further activity occurs. Thanks for the feedback.

@github-actions github-actions bot added the stale 15 days without activity label Aug 24, 2024
Copy link

Due to the lack of activity in the last 5 days since it was marked as "stale", we proceed to close this Issue. Do not hesitate to reopen it later if necessary.

@bitnami-bot bitnami-bot closed this as not planned Won't fix, can't repro, duplicate, stale Aug 29, 2024
@TomyLobo
Copy link

I also have this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
external-dns feature-request solved stale 15 days without activity triage Triage is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants