Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: allow changing the default revisionHistoryLimit #1286

Merged
merged 2 commits into from
Aug 8, 2023
Merged

feat: allow changing the default revisionHistoryLimit #1286

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
74ab10a
feat: allow changing the default revisionHistoryLimit
tberreis Aug 3, 2023
098f288
chore: move revisionHistoryLimit to sealed secrets parameters section…
Aug 8, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions helm/sealed-secrets/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,6 +88,7 @@ The command removes all the Kubernetes components associated with the chart and
| `image.tag` | Sealed Secrets image tag (immutable tags are recommended) | `v0.23.0` |
| `image.pullPolicy` | Sealed Secrets image pull policy | `IfNotPresent` |
| `image.pullSecrets` | Sealed Secrets image pull secrets | `[]` |
| `revisionHistoryLimit` | Number of old history to retain to allow rollback. Default 10 | `""` |
| `createController` | Specifies whether the Sealed Secrets controller should be created | `true` |
| `secretName` | The name of an existing TLS secret containing the key used to encrypt secrets | `sealed-secrets-key` |
| `updateStatus` | Specifies whether the Sealed Secrets controller should update the status subresource | `true` |
Expand Down
3 changes: 3 additions & 0 deletions helm/sealed-secrets/templates/deployment.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,9 @@ metadata:
{{- end }}
spec:
replicas: 1
{{- if .Values.revisionHistoryLimit }}
revisionHistoryLimit: {{ .Values.revisionHistoryLimit }}
{{- end }}
selector:
matchLabels: {{- include "sealed-secrets.matchLabels" . | nindent 6 }}
template:
Expand Down
4 changes: 4 additions & 0 deletions helm/sealed-secrets/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ fullnameOverride: ""
## @param namespace Namespace where to deploy the Sealed Secrets controller
##
namespace: ""

## @param extraDeploy [array] Array of extra objects to deploy with the release
##
extraDeploy: []
Expand Down Expand Up @@ -47,6 +48,9 @@ image:
## - myRegistryKeySecretName
##
pullSecrets: []
## @param revisionHistoryLimit Number of old history to retain to allow rollback (If not set, default Kubernetes value is set to 10)
## e.g:
revisionHistoryLimit: ""
## @param createController Specifies whether the Sealed Secrets controller should be created
##
createController: true
Expand Down