feat: allow changing the default revisionHistoryLimit #1286
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tberreis
requested review from
alvneiayu,
agarcia-oss and
alemorcuq
as code owners
alemorcuq
suggested changes
Aug 7, 2023
helm/sealed-secrets/values.yaml
Outdated
| @@ -12,6 +12,10 @@ fullnameOverride: "" | |||
| ## @param namespace Namespace where to deploy the Sealed Secrets controller | |||
| ## | |||
| namespace: "" | |||
| ## @param revisionHistoryLimit Number of old history to retain to allow rollback (If not set, default Kubernetes value is set to 10) | |||
| ## e.g: | |||
| ## revisionHistoryLimit: 1 | |||
There was a problem hiding this comment.
Suggested change
| ## revisionHistoryLimit: 1 | |
| revisionHistoryLimit: "" |
I would also move this a bit down, under the "Sealed Secrets Parameters" section.
Could you please add this parameter to the readme too?
There was a problem hiding this comment.
Thank you for your feedback @alemorcuq. Code has been adapted.
Signed-off-by: Thomas Berreis <[email protected]>
…, update readme Signed-off-by: Thomas Berreis <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
The deployment has been adapted to allow the user changing the default revisionHistoryLimit.
Benefits
You may want to clean up old replicasets so that these don't appear in metrics, OPA violations, ArgoCD UI and so on.
Therefore you want to overwrite the Kubernetes default revision history limit.
Possible drawbacks
N/A
Applicable issues
N/A
Additional information
N/A