Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add logic to have separated translations by language #417

Merged
merged 10 commits into from
Sep 23, 2024
Merged

Add logic to have separated translations by language #417

merged 10 commits into from
Sep 23, 2024

Conversation

ZIMkaRU
Copy link
Member

@ZIMkaRU ZIMkaRU commented Sep 20, 2024

This PR adds logic to have separated translations by language in JSON files using i18next lib for easier translation maintenance

Basic changes:

  • extend the translation flow of the main repository
  • store translations in one common folder in the root
  • separate translations by language in JSON files using namespaces
  • inject I18next service to extended PdfWriter
  • cleanup redundant yaml translations

Depends on this PR:

ezewer
ezewer approved these changes Sep 23, 2024
View reviewed changes
Copy link
Contributor

@ezewer ezewer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@ezewer ezewer merged commit 3643af6 into bitfinexcom:staging Sep 23, 2024
This was referenced Sep 23, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ezewer ezewer ezewer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ZIMkaRU @ezewer