Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add logic to have separated translations by language #402

Merged
merged 27 commits into from
Sep 23, 2024
Merged

Add logic to have separated translations by language #402

merged 27 commits into from
Sep 23, 2024

Conversation

ZIMkaRU
Copy link
Member

@ZIMkaRU ZIMkaRU commented Sep 20, 2024

This PR adds logic to have separated translations by language in JSON files using i18next lib for easier translation maintenance

Basic changes:

  • store translations in one common folder in the root
  • separate translations by language in JSON files using namespaces
  • extend the official i18next-fs-backend plugin to provide the ability to load and merge translations in the bfx-reports-framework
  • provide correct i18next initialization in the main service
  • rework logic to use i18next lib API
  • cleanup redundant yaml translations and js-yaml dependency

prdn and others added 27 commits September 10, 2024 16:06
@prdn
Merge pull request bitfinexcom#401 from bitfinexcom/staging
8399316 
Release version to master
@ZIMkaRU
Implement fs multiplication backend for i18next
0ccc032
@ZIMkaRU
Implement module to get i18next configured instance
6e287f2
@ZIMkaRU
Add simple locales for i18next
2e555c7
@ZIMkaRU
Add initialization flow for i18next into entrypoint
a6cbbab
@ZIMkaRU
Add i18next and i18next-fs-backend to prod deps
dbcda7a
@ZIMkaRU
Add di type for I18next
a5c5217
@ZIMkaRU
Add I18next service to di
6a62f39
@ZIMkaRU
Inject i18next into di
025bf75
@ZIMkaRU
Improve i18next factory
75bf9ae
@ZIMkaRU
Add en translation in json
5693739
@ZIMkaRU
Add ru translation in json
1e558f5
@ZIMkaRU
Add es translation in json
708859d
@ZIMkaRU
Add pt translation in json
d98bf82
@ZIMkaRU
Add tr translation in json
a01b29c
@ZIMkaRU
Add zh-cn translation in json
b111e45
@ZIMkaRU
Add zh-tw translation in json
6f8dd41
@ZIMkaRU
Inject I18next to SendMail service
b6cb2e8
@ZIMkaRU
Rework pug translator to use i18next api
f96d84c
@ZIMkaRU
Rework SendMail service to use i18next api
45f3345
@ZIMkaRU
Add translation namespaces
e9ef8ea
@ZIMkaRU
Use common translation namespaces in i18next service
b488fe1
@ZIMkaRU
Rework PdfWriter service to use i18next api
584ac80
@ZIMkaRU
Remove redundant email translation yaml file
7d31910
@ZIMkaRU
Remove redundant pdf translation yaml file
ca3d2f2
@ZIMkaRU
Remove redundant language file
728a069
@ZIMkaRU
Remove redundant js-yaml dep
79f5af0
@ZIMkaRU ZIMkaRU mentioned this pull request Sep 20, 2024
Merged
ezewer
ezewer approved these changes Sep 23, 2024
View reviewed changes
Copy link
Contributor

@ezewer ezewer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@ezewer ezewer merged commit fa668c0 into bitfinexcom:staging Sep 23, 2024
This was referenced Sep 23, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ezewer ezewer ezewer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ZIMkaRU @ezewer @prdn