Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add an artifact ID to the artifact intent/upload requests #40

Merged
merged 8 commits into from
Feb 20, 2025
Merged

add an artifact ID to the artifact intent/upload requests #40

Changes from 7 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
feae8ed
add file artifact proto wrapper
Feb 19, 2025
df54749
comment
Feb 19, 2025
baf1f9b
type
Feb 19, 2025
2171bfa
header
Feb 19, 2025
2acc9c5
Merge branch 'main' of github.com:bitdriftlabs/api into add-file-uplo…
Feb 19, 2025
16c7bde
put artifact id on upload
Feb 19, 2025
67df09f
remove pgv
Feb 20, 2025
c995009
Update src/bitdrift_public/protobuf/client/v1/api.proto
snowp Feb 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion src/bitdrift_public/protobuf/client/v1/api.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -256,6 +256,10 @@ message UploadArtifactIntentRequest {
// The metadata associated with the artifact. This is a binary blob that is interpreted by the server
// based on the type_id.
bytes metadata = 3;

// A client-generated ID that uniquely identifies the artifact. This is used to correlate the artifact
// with logs that reference it.
string artifact_id = 4 [(validate.rules).string = {min_len: 1}];
Comment on lines +260 to +262
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel like the intent_uuid and the upload_uuid below can probably be used for this, but it doesn't really matter if you want to keep them independent for future proofing.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah I had the same thought but seemed nice to have it split in case these two end up diverging

}

message UploadArtifactIntentResponse {
Expand Down Expand Up @@ -285,7 +289,11 @@ message UploadArtifactRequest {
string type_id = 2 [(validate.rules).string = {min_len: 1}];

// The artifact to upload. This is a binary blob that is interpreted by the server based on the type_id.
bytes contents = 3 [(validate.rules).bytes = {min_len: 1}];
bytes contents = 3;

// A client-generated ID that uniquely identifies the artifact being uploaded.. This is used to correlate
// the artifact with logs that reference it.
string artifact_id = 4 [(validate.rules).string = {min_len: 1}];
}

message UploadArtifactResponse {
Expand Down
Loading