add an artifact ID to the artifact intent/upload requests #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
February 19, 2025 15:37
This will be used to wrap the file contents and include a client-generated ID for the upload
snowp
changed the title
mattklein123
approved these changes
Feb 20, 2025
Comment on lines
+260
to
+262
| // A client-generated ID that uniquely identifies the artifact. This is used to correlate the artifact | ||
| // with logs that reference it. | ||
| string artifact_id = 4 [(validate.rules).string = {min_len: 1}]; |
There was a problem hiding this comment.
I feel like the intent_uuid and the upload_uuid below can probably be used for this, but it doesn't really matter if you want to keep them independent for future proofing.
There was a problem hiding this comment.
Yeah I had the same thought but seemed nice to have it split in case these two end up diverging
Co-authored-by: Matt Klein <[email protected]> Signed-off-by: Snow Pettersen <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will be used to wrap the file contents and include a client-generated ID for the upload