Disable controller selection if OOT controller is selected #1397
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is more intuitive, especially considering the configuration GUIs
This reverts commit 159776e.
|
Perhaps this is why it was named "default" controller? Can we remove the "default" now? |
gemenerik
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, kconfig allows both one of the implemented controllers + the OOT controller to be selected. Since only one can be used at a time this resulted in the implemented controller being used over the OOT controller (due to the order of how they are checked in
controller.c. This PR keeps the config/menu structure the same, but when OOT controller is selected, this automatically disables the choice of regular controller.Visualized in menuconfig:
