Toverumar/mutual excl idlethrust #1384
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…igher than 0. Will only stop build time misconfiguration
|
What do you think about also limiting this for anything that is a quad but is not a brushless? This is how it is now. Should we check so that it will only limit it if its a brushless? |
We need to override the idleThrust param stored in eeprom with 0 if arming is not on The (brushless) motors needs to be fed a 0 signal after they started up and we do not know exactly when that is. These two features are mutually eclusive and can not be used together
ToveRumar
force-pushed
the
toverumar/mutual_excl_idlethrust
branch
from
f8aa1c4
to
aa03faa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Idle thrust can not be higher than 0 if autoarm is on (i.e the device is unarmed from start).
This is due to the ESCs for the brushless motors (only BL needs idle thrust) needs to receive a 0 signal before any other pwm signal to start.
The ESC wakeup time is not something we keep track of in the Firmware and so to get these to features to work simultaneously would require some work. We do not see it as necessary to be able to do both as of now.
For this reason we want to limit the use of these together.
We limit them both at run time and at build time.