Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update bdk dependency to 0.22 #118

Merged
merged 1 commit into from
Sep 9, 2022

Conversation

notmandatory
Copy link
Member

@notmandatory notmandatory commented Sep 5, 2022

Description

  • Update bdk and bdk-reserves to v0.22.0.
  • Change rpc --skip-blocks option to --start-time which specifies time initial sync will start scanning from.

Notes to the reviewers

I haven't verified the bits and bytes of the new reserves PSBT in the tests. I assume it's different for the same reason as the other tests in bdk-reserves when we switched to bdk 0.22, but I could use some help confirming that.

This is draft until bdk and bdk-reservers v0.22 are published.

Checklists

All Submissions:

  • I've signed all my commits
  • I followed the contribution guidelines
  • I ran cargo fmt and cargo clippy before committing

@notmandatory notmandatory self-assigned this Sep 5, 2022
@notmandatory notmandatory added this to the Release 0.6.0 milestone Sep 5, 2022
@notmandatory notmandatory force-pushed the update_bdk022 branch 8 times, most recently from b1e4b0e to 54036b3 Compare September 5, 2022 21:08
@notmandatory notmandatory marked this pull request as draft September 5, 2022 21:27
@notmandatory notmandatory mentioned this pull request Sep 5, 2022
21 tasks
Copy link
Contributor

@rajarshimaitra rajarshimaitra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tACK c013266

Thanks for the PR, I probably misunderstood the new update process.. I should have made the update as a fresh PR itself.. This is much cleaner..

I verified that the psbt only changed in omitted partial signatures.

From this PR

Input {
            non_witness_utxo: None,
            witness_utxo: Some(
                TxOut {
                    value: 100000,
                    script_pubkey: Script(OP_0 OP_PUSHBYTES_20 ece526571053da86454c9e066779eaf9d1502e6a),
                },
            ),
            partial_sigs: {},
            sighash_type: None,

From master

Input {
            non_witness_utxo: None,
            witness_utxo: Some(
                TxOut {
                    value: 10000,
                    script_pubkey: Script(OP_0 OP_PUSHBYTES_20 ece526571053da86454c9e066779eaf9d1502e6a),
                },
            ),
            partial_sigs: {
                PublicKey {
                    compressed: true,
                    inner: PublicKey(
                        e38744d6bf154145115968917eae5d57e20393653d93844a6938ec8b0758052bbd4f42a158da428c7a96a02ec380440540f08979145cb9216fade06e3088a5e1,
                    ),
                }: EcdsaSig {
                    sig: 30450221009c2f349bd0e1a366dbe201a11b7f567b1018576510e8b3cc60d5c79a51f7a34c022000c22e1bc207fc26cfe7d4c792779dea0e8e848b1e94dcebfc9ac29ec4c58a5b,
                    hash_ty: All,
                },
            },
            sighash_type: None,
            redeem_script: None,

@notmandatory notmandatory mentioned this pull request Sep 6, 2022
6 tasks
notmandatory added a commit to bitcoindevkit/bdk-reserves that referenced this pull request Sep 8, 2022
1bf97ec Add cargo update step to CI Build and Test (Steve Myers)
e08ea81 Update bdk dependency to 0.22 (Steve Myers)

Pull request description:

  This update also required recalculating the PSBT proofs due to BDK removing partial signatures, see bitcoindevkit/bdk-cli#118 (review).

  Once this PR is merged I'll publish a new `bdk-reserves` release version `0.22.0`.

Top commit has no ACKs.

Tree-SHA512: 972e51e9ab8dbbff869ce1b8916abf7781e3b30ac671bb719e82d8803b8c56aa3cff723762d2c771cb17bc6d71296bff7c9fee93312316d1162d18f99f35fbee
@notmandatory notmandatory marked this pull request as ready for review September 8, 2022 17:43
@notmandatory
Copy link
Member Author

I've updated with newly published bdk and bdk-reserves version 0.22, PR now ready for final review/approval.

Copy link
Contributor

@rajarshimaitra rajarshimaitra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK e8b2028

This is good to go..

@notmandatory notmandatory merged commit 99a329f into bitcoindevkit:master Sep 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants