-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update bdk dependency to 0.22 #118
Conversation
b1e4b0e
to
54036b3
Compare
54036b3
to
c013266
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tACK c013266
Thanks for the PR, I probably misunderstood the new update process.. I should have made the update as a fresh PR itself.. This is much cleaner..
I verified that the psbt only changed in omitted partial signatures.
From this PR
Input {
non_witness_utxo: None,
witness_utxo: Some(
TxOut {
value: 100000,
script_pubkey: Script(OP_0 OP_PUSHBYTES_20 ece526571053da86454c9e066779eaf9d1502e6a),
},
),
partial_sigs: {},
sighash_type: None,
From master
Input {
non_witness_utxo: None,
witness_utxo: Some(
TxOut {
value: 10000,
script_pubkey: Script(OP_0 OP_PUSHBYTES_20 ece526571053da86454c9e066779eaf9d1502e6a),
},
),
partial_sigs: {
PublicKey {
compressed: true,
inner: PublicKey(
e38744d6bf154145115968917eae5d57e20393653d93844a6938ec8b0758052bbd4f42a158da428c7a96a02ec380440540f08979145cb9216fade06e3088a5e1,
),
}: EcdsaSig {
sig: 30450221009c2f349bd0e1a366dbe201a11b7f567b1018576510e8b3cc60d5c79a51f7a34c022000c22e1bc207fc26cfe7d4c792779dea0e8e848b1e94dcebfc9ac29ec4c58a5b,
hash_ty: All,
},
},
sighash_type: None,
redeem_script: None,
c013266
to
4e2433e
Compare
1bf97ec Add cargo update step to CI Build and Test (Steve Myers) e08ea81 Update bdk dependency to 0.22 (Steve Myers) Pull request description: This update also required recalculating the PSBT proofs due to BDK removing partial signatures, see bitcoindevkit/bdk-cli#118 (review). Once this PR is merged I'll publish a new `bdk-reserves` release version `0.22.0`. Top commit has no ACKs. Tree-SHA512: 972e51e9ab8dbbff869ce1b8916abf7781e3b30ac671bb719e82d8803b8c56aa3cff723762d2c771cb17bc6d71296bff7c9fee93312316d1162d18f99f35fbee
4e2433e
to
e8b2028
Compare
I've updated with newly published |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK e8b2028
This is good to go..
Description
bdk
andbdk-reserves
to v0.22.0.--skip-blocks
option to--start-time
which specifies time initial sync will start scanning from.Notes to the reviewers
I haven't verified the bits and bytes of the new
reserves
PSBT in the tests. I assume it's different for the same reason as the other tests inbdk-reserves
when we switched to bdk 0.22, but I could use some help confirming that.This is draft until
bdk
andbdk-reservers
v0.22 are published.Checklists
All Submissions:
cargo fmt
andcargo clippy
before committing