-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update bdk dependency to 0.22 #11
Conversation
@ulrichard I did the basic changes to update to the bdk 0.22 release candidate. Do you have time to investigate why some tests are failing? |
6ab600e
to
47719f9
Compare
Thanks @notmandatory for the PR.. Code changes looks good to me.. Here's the possible reason why the tests might be failing.
|
47719f9
to
dadb44c
Compare
@rajarshimaitra thanks for the tip! yes I did have to re-calculate the proof PSBT and that fixed the tests. I think the difference is caused by the new PSBT default signing options, on finalize remove partial signatures. I didn't check the individual bits and bytes but the new PSBTs are much smaller. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tACK dadb44c
Thanks for figuring the psbt @notmandatory!! This works..
99f565f
to
71cfb91
Compare
71cfb91
to
e08ea81
Compare
Sorry for the late reaction. I was busy with other things. Looks all good to me. Thanks for your efforts. |
This update also required recalculating the PSBT proofs due to BDK removing partial signatures, see bitcoindevkit/bdk-cli#118 (review).
Once this PR is merged I'll publish a new
bdk-reserves
release version0.22.0
.