BIP-85: Add language code & dice app, TPRV guidance, warn on BIP-32 divergence, grammar & clarity

[akarve]

Reloading this PR with minimal, backward-compatible changes.

• I believe there is consensus on the need to add a new champion here.
• The reason for adding a new reference implementation is to support Python 3.x with a thoroughly unit-tested implementation. I was unable to get the original Python 2.x reference implementation to run.
• If desired I can email bitcoin dev for more thoughts on these changes

[akarve]

@jonatack @scgbckbone Please have look.

[scgbckbone]

wrong entropy is in base64 pwd application, currently:
d7ad61d4a76575c5bad773feeb40299490b224e8e5df6c8ad8fe3d0a6eed7b85ead9fef7bcca8160f0ee48dc6e92b311fc71f2146623cc6952c03ce82c7b63fe

correct:
74a2e87a9ba0cdd549bdd2f9ea880d554c6c355b08ed25088cfa88f3f1c4f74632b652fd4a8f5fda43074c6f6964a3753b08bb5210c8f5e75c07a4c2a20bf6e9

[scgbckbone]

could you possibly split this into "b64 entropy fix only PR" and "the rest" ?

[akarve]

could you possibly split this into "b64 entropy fix only PR" and "the rest" ?

Yeahbut I’d also include the BIP32 comment because it’s a fact.

[jonatack]

Thank you for opening this, was going to ask. If this is to be done, seems best to do it before updating the BIP status to Final in #1676.

• Can you prefix each commit message with BIP85: or refer to it in the commit title?

• Consider doing the test vector correction in a separate commit with a full explanation of what was incorrect and the fix.

• Can you also provide an explanation of the Base64 entropy fix in the commit message.

• Please provide a better commit message for the "add warning" commit.

• Did you want to make the changes in the abstract and definitions sections that you did in #1600?

cc @nvk for review

[scgbckbone]

Can you also provide an explanation of the Base64 entropy fix in the commit message.

@jonatack this is my bug when I was adding base64 app to the BIP, seems it went unnoticed for long time...

[akarve]

Can you also provide an explanation of the Base64 entropy fix in the commit message.

@jonatack this is my bug when I was adding base64 app to the BIP, seems it went unnoticed for long time...

Here's the standalone fix: #1683

[akarve]

Did you want to make the changes in the abstract and definitions sections that you did in #1600?

I want to but not in this changeset. Let's get through the hard parts then we can optimize on top of that. I'm tryna keep the changesets as small as possible for now.

[jonatack]

Might be good to add a changelog in this pull, as previously in #1600.

[jonatack]

Ok, I see that https://github.com/akarve/bipsea has been updated.

[jonatack]

do committers squash and merge? if not should i rebase this? I was asked to preface all commits with BIP-85, and these commits are all orthogonal and semantic, but I personally would prefer a rebase because a lot of this is TMI for master, agree?

People have different preferences. I prefer when the PR author organizes the commits in a logical, hygienic manner; and otherwise, I might squash in the merge to one commit.

[akarve]

@jonatack i've added a real changelog so that the semvers are more... semantic. i could go deeper in terms of detail (fixes, etc.) but this seems complete enough to be useful and importantly puts this commit at semver 1.3.0.

[jonatack]

Suggest "Changelog" (no space), with entries ordered by most recent first (see https://keepachangelog.com/en/1.1.0/).

[jonatack]

Seems close, modulo a couple suggestions.

Pinging @scgbckbone @nvk @Rob1Ham @luisschwab for review/comments.

Reviewers: suggest looking at the whole change, not commit-by-commit.

[jonatack]

Perhaps it would be easier for readers to reference these versions by moving this Reference Implementation section to just above the Changelog (and move the Acknowledgements section further down toward the end).

[jonatack]

Suggest "Changelog" (no space), with entries ordered by most recent first (see https://keepachangelog.com/en/1.1.0/).

[scgbckbone]

ACK (but expect #1676 to follow)

[jonatack]

Thanks for looking @scgbckbone.

ACK 0e5f2da