BIP85: update status to Final #1676
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonatack
reviewed
Oct 5, 2024
scgbckbone
force-pushed
the
bip85_final
branch
from
a6f7a8c to
03edc79
Compare
scgbckbone
force-pushed
the
bip85_final
branch
from
03edc79 to
b012550
Compare
|
ACK b012550 For context, this change was recommended yesterday in #1600 (comment). BIP author @ethankosakovsky has been unresponsive for a long time but would be good to see community feedback here. |
|
ACK |
1 similar comment
|
ACK |
|
ACK b012550 |
1 similar comment
|
ACK b012550 |
akarve
reviewed
Oct 6, 2024
| | Ethan Kosakovsky | ||
| | Informational | ||
| | Draft | ||
| | Final |
There was a problem hiding this comment.
Why Final and not Proposed per this comment?
There was a problem hiding this comment.
comment states "propsed or final", this BIP should be final as it is widely deployed and used by many projects.
1 task
|
Waiting for #1679 outcome before merge here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moving this BIP to final stage as this is widely deployed