rework termination mac handling #396
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These now work stable, so we don't need to mark them as experimental anymore. Signed-off-by: Jonas Gorski <[email protected]>
KNET interfaces on switch work stable, and offer more throughput and lower latency, and avoid the issue of traffic to/from controller overloading the OpenFlow connection. So switch to them as default. Signed-off-by: Jonas Gorski <[email protected]>
enable KNET interfaces by default
Add a new function to control wether packets should be marked as switching offloaded in hardware. Signed-off-by: Jonas Gorski <[email protected]>
Add a new flag mark_fwd_offload to enable marking switched packets as offloaded, and default to true. This flag, when set on packets, will tell the kernel that the packet was already forwarded/flooded in hardware, and will prevent packet duplication. Signed-off-by: Jonas Gorski <[email protected]>
Implement ::set_offloaded for knet_manager by setting the appropriate flag via /proc. Signed-off-by: Jonas Gorski <[email protected]>
mark packets as offloaded when using KNET
Just get the port id once, and check it as needed. Makes the code slightly less complex. Signed-off-by: Jonas Gorski <[email protected]>
Add support for setting the port config. For now only support setting a port up or down by sending an appropriate port_mod message. Signed-off-by: Jonas Gorski <[email protected]>
OF-DPA requires the correct (internal) MAC address set for all port_mod messages, so we need to store it when we first create the port interfaces. Signed-off-by: Jonas Gorski <[email protected]>
Propagate port admin config of ports to the switch so they follow the port admin config in linux. Signed-off-by: Jonas Gorski <[email protected]>
Any newly created interface will start as being down, so we should make sure that the configuration in the switch reflects that. Signed-off-by: Jonas Gorski <[email protected]>
cnetlink: propagate admin port config
KanjiMonster
force-pushed
the
jogo_termmac_rework
branch
from
9e1966d to
3400a47
Compare
Rework termination mac handling by tying termination mac entries to interfaces: * create entries on interface creation * remove them on interface deletion with the values of * port_id, vid 0 for the base port/bond interface (any vid) * port_id, vid for vlan interfaces on top of those * port_id 0, vid 0 for the base bridge interface (any port, any vid) * port_id 0, vid for vlan interface on top of bridge Since these combinations are unique, we can just add/remove the entries without the need of having refcounts. Advantages: * simplication of code * ip addresses assigned to lo will just work Disadvantages: * higher use of termination mac flows, which are limited (0.5k to 1k), so only (256 - ports) to (512 - ports) number of vlan/bridge/bond interfaces are supported * (this is a lie though, since both termination mac entries for an interface share the same underlying resource) Signed-off-by: Jonas Gorski <[email protected]>
KanjiMonster
force-pushed
the
jogo_termmac_rework
branch
from
3400a47 to
ea27328
Compare
KanjiMonster
force-pushed
the
baseboxd-2.0
branch
from
3c6cdba to
7886f8b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rework termination mac handling by tying termination mac entries to
interfaces:
with the values of
Since these combinations are unique, we can just add/remove the entries
without the need of having refcounts.
Advantages:
Disadvantages:
so only (256 - ports) to (512 - ports) number of vlan/bridge/bond
interfaces are supported
interface share the same underlying resource)
Open Questions:
resources?
Signed-off-by: Jonas Gorski [email protected]