mark packets as offloaded when using KNET #393
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a new function to control wether packets should be marked as switching offloaded in hardware. Signed-off-by: Jonas Gorski <[email protected]>
Add a new flag mark_fwd_offload to enable marking switched packets as offloaded, and default to true. This flag, when set on packets, will tell the kernel that the packet was already forwarded/flooded in hardware, and will prevent packet duplication. Signed-off-by: Jonas Gorski <[email protected]>
Implement ::set_offloaded for knet_manager by setting the appropriate flag via /proc. Signed-off-by: Jonas Gorski <[email protected]>
KanjiMonster
force-pushed
the
jogo_knet_mark_as_offloaded
branch
from
214f5ce to
5ad9fd3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Linux will flood/forward any packets it sees on a bridge by default. This can lead to packet duplication if the packet was already forwarded/flooded by the ASIC. This can be avoided by marking packets as forwarding being offloaded, so tell KNET to mark any received packets as such.
To allow disabling it in case of unexpected side effects, add a flag for controlling the behavior.
The implementation is kept as generic as possible, in case we ever implement it for TAP interfaces as well.
Signed-off-by: Jonas Gorski [email protected]