Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update URI formats for tair.locus and tair.protein #1386

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

bgyori
Copy link
Contributor

@bgyori bgyori commented Jan 28, 2025

This PR partially addresses #1335 by adding new URI formats for tair.locus and tair.protein. The latter is using a pattern that @nagutm found, and after some trial and error, I found a URI format that works for the former. I didn't manage to find any working URI format for resolving tair.gene identifiers.

Copy link
Member

@cthoyt cthoyt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please make sure not to throw away old URI formats when making updates, these are still required to parse data that is out in the wild. When making these kinds of updates, one can put the old URI formats into a provider, where one can also give context as to why they were removed in the description field

@bgyori
Copy link
Contributor Author

bgyori commented Jan 28, 2025

I agree preserving the old URL has some utility but if we curate it as a provider, wouldn't it appear as a broken resolver link on the website? Would it make sense to introduce a dedicated slot in the schema for legacy URLs that are known to be outdated but are used specifically for the purpose of reverse mapping of URLs to CURIEs?

@cthoyt
Copy link
Member

cthoyt commented Jan 29, 2025

Agreed, I think introducing a controlled vocabulary for "status" in the Provider class would accomplish this - then we could flag things as being "legacy" URLs that either still can be resolved or not.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants