Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove DOID mappings where primary mappings exist #79

Merged
merged 1 commit into from
Nov 14, 2021
Merged

Conversation

bgyori
Copy link
Contributor

@bgyori bgyori commented Nov 14, 2021

This PR removes DOID mapping predictions where DO (as a primary provider) already provides mappings to MeSH, UMLS or EFO for a given DOID. For instance, if for a given DOID, there already exists a mapping to UMLS and EFO but not the MeSH, any UMLS and EFO predictions are removed from here and any MeSH predictions here are retained.

@bgyori bgyori changed the title Remove DOID-MeSH mappings where primary mappings exist Remove DOID mappings where primary mappings exist Nov 14, 2021
@bgyori
Copy link
Contributor Author

bgyori commented Nov 14, 2021

The before/after mappings counts are as follows:

DOID-MESH: 2924->451
DOID-UMLS: 8805->2467
DOID-EFO: 2267->2142

In other words, the majority of mappings to MESH and UMLS were redundant since they were already available from DO, but most of the EFO mappings are potentially non-redundant and useful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant