-
-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Curate additional DOID-MESH mappings and contribute to DOID #104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bgyori
force-pushed
the
doid_curation
branch
from
September 20, 2022 18:59
7c72b73
to
2a56f32
Compare
@cthoyt I realize we haven't wrapped this up yet. Currently it's stuck due to having to decide on the conventions for MONDO IDs, which is actually dependent on how we decide to handle MONDO on the Bioregistry side. To recap, choices are:
|
I’d like to go with B. We shouldn’t make any assumptions about what identifiers.org might do for resources it hasn’t curated. |
cthoyt
approved these changes
Oct 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does the following:
Note that some, relatively less reliable predictions originally produced by https://github.com/biopragmatics/biomappings/blob/master/scripts/generate_doid_mappings.py were removed, though these do contain at least some correct predictions, though in principle, this new script would have found the same matches if they were non-redundant and one-to-one.