refactor(markdown_parser): deduplicate normalize_html test helper#9833
Conversation
Extract shared `normalize_html` function into `tests/test_utils.rs` and import from both `spec_test.rs` and `fuzz_differential.rs` to prevent the two copies from silently diverging.
|
Merging this PR will not alter performance
Comparing Footnotes
|
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (4)
WalkthroughThe PR consolidates duplicate HTML normalisation logic from markdown parser test files into a centralised shared utility module. Two test files ( Possibly related PRs
Suggested reviewers
🚥 Pre-merge checks | ✅ 2✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Note
This PR was created with AI assistance (Claude Code).
Summary
Extracts the shared
normalize_htmltest helper intotests/test_utils.rs. Bothspec_test.rsandfuzz_differential.rsmaintained identical local copies of this function, which could silently diverge if one is updated without the other.Test Plan
just test-crate biome_markdown_parser— all 84 spec tests passjust test-markdown-conformance— 652/652, 100% coverage, 0 panicsDocs
N/A