Skip to content

refactor(markdown): cleanup nits from #9746#9751

Merged
dyc3 merged 1 commit intobiomejs:mainfrom
jfmcdowell:refactor/markdown-cleanup-nits
Mar 31, 2026
Merged

refactor(markdown): cleanup nits from #9746#9751
dyc3 merged 1 commit intobiomejs:mainfrom
jfmcdowell:refactor/markdown-cleanup-nits

Conversation

@jfmcdowell
Copy link
Copy Markdown
Contributor

Note

This PR was created with AI assistance (Claude Code).

Summary

Small follow-up to #9746.

  • Use try_bump_quote_marker in the depth-overflow recovery path instead of duplicating the quote-marker consumption logic.
  • Update three stale doc comments that referenced "skipped trivia" to reflect the current Whitespace trivia model.

Test Plan

  • just test-crate biome_markdown_parser

Docs

N/A.

Replace duplicated quote-marker consumption logic in the
depth-overflow recovery branch with try_bump_quote_marker.
@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Mar 31, 2026

⚠️ No Changeset found

Latest commit: 3fd04d2

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@jfmcdowell jfmcdowell marked this pull request as draft March 31, 2026 13:20
@github-actions github-actions bot added A-Parser Area: parser L-Markdown Language: Markdown labels Mar 31, 2026
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Mar 31, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: d556712a-9b67-40e9-bca4-3df516a44972

📥 Commits

Reviewing files that changed from the base of the PR and between d94b8ac and 3fd04d2.

📒 Files selected for processing (3)
  • crates/biome_markdown_parser/src/syntax/list.rs
  • crates/biome_markdown_parser/src/syntax/quote.rs
  • crates/biome_markdown_parser/src/to_html.rs

Walkthrough

This PR updates documentation and comments across the Markdown parser to reflect terminology changes and consolidate code logic. Comment text in compute_marker_indent now describes leading whitespace as "consumed as trivia" rather than "skipped as trivia". The parse_quote recovery path consolidates inline > marker detection into a shared helper function. Documentation strings in to_html.rs use more general terminology for whitespace and trivia handling. Underlying code behaviour remains unchanged.

Possibly related PRs

  • PR 9717: Updates compute_marker_indent and virtual-line handling logic in the same list marker indentation code
  • PR 9746: Restructures the parse_quote recovery path and marker-consumption logic in the same file

Suggested labels

A-Parser, L-Markdown

Suggested reviewers

  • dyc3
  • ematipico
🚥 Pre-merge checks | ✅ 2
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly describes the main change: a cleanup refactor of nits (small issues) related to a previous PR, specifically in the markdown parser.
Description check ✅ Passed The description is directly related to the changeset, clearly explaining the two main improvements: consolidating quote-marker logic and updating stale documentation comments.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@jfmcdowell jfmcdowell marked this pull request as ready for review March 31, 2026 13:26
@codspeed-hq
Copy link
Copy Markdown

codspeed-hq bot commented Mar 31, 2026

Merging this PR will not alter performance

✅ 28 untouched benchmarks
⏩ 228 skipped benchmarks1


Comparing jfmcdowell:refactor/markdown-cleanup-nits (3fd04d2) with main (d94b8ac)

Open in CodSpeed

Footnotes

  1. 228 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@dyc3 dyc3 merged commit 16d37a4 into biomejs:main Mar 31, 2026
15 checks passed
@jfmcdowell jfmcdowell deleted the refactor/markdown-cleanup-nits branch April 13, 2026 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-Parser Area: parser L-Markdown Language: Markdown

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants