Skip to content

test(markdown): add regression tests for mixed list markers across blank lines#9732

Merged
ematipico merged 1 commit intobiomejs:mainfrom
jfmcdowell:fix-md-list-delim-regression-tests
Mar 30, 2026
Merged

test(markdown): add regression tests for mixed list markers across blank lines#9732
ematipico merged 1 commit intobiomejs:mainfrom
jfmcdowell:fix-md-list-delim-regression-tests

Conversation

@jfmcdowell
Copy link
Copy Markdown
Contributor

Note

This PR was created with AI assistance (Claude Code).

Summary

Closes #9729, closes #9731.

Adds regression tests verifying that mixed ordered delimiters (. vs )) and mixed bullet markers (- vs +) separated by blank lines produce separate lists. The parser already handles this correctly — these tests lock in the behavior.

Test Plan

  • just test-crate biome_markdown_parser
  • just test-markdown-conformance — 652/652
  • just f
  • just l

Docs

N/A.

…ank lines

Verifies that mixed ordered delimiters (`.` vs `)`) and mixed bullet
markers (`-` vs `+`) separated by blank lines produce separate lists.

Closes biomejs#9729, closes biomejs#9731.
@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Mar 30, 2026

⚠️ No Changeset found

Latest commit: fb27fa6

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added A-Parser Area: parser L-Markdown Language: Markdown labels Mar 30, 2026
@codspeed-hq
Copy link
Copy Markdown

codspeed-hq bot commented Mar 30, 2026

Merging this PR will not alter performance

✅ 28 untouched benchmarks
⏩ 228 skipped benchmarks1


Comparing jfmcdowell:fix-md-list-delim-regression-tests (fb27fa6) with main (467fd87)

Open in CodSpeed

Footnotes

  1. 228 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@jfmcdowell jfmcdowell marked this pull request as ready for review March 30, 2026 19:20
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Mar 30, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 5dccf143-5cf9-44cb-a5e5-ff6491edadfd

📥 Commits

Reviewing files that changed from the base of the PR and between 467fd87 and fb27fa6.

📒 Files selected for processing (1)
  • crates/biome_markdown_parser/tests/spec_test.rs

Walkthrough

This PR adds two test cases to validate HTML rendering behaviour for list delimiters across blank lines. Test case 10005 asserts that switching ordered list delimiters from 1. to 2) across a blank line produces two separate <ol> elements with the second preserving start="2". Test case 10006 asserts that switching bullet markers from - to + across a blank line produces two separate <ul> elements. No modifications to existing test logic or expectations.

Possibly related PRs

  • biomejs/biome#9717 — Modifies list end and blank-line lookahead logic in the parser that directly affects list-splitting and start-attribute preservation behaviour tested by these new cases.

Suggested reviewers

  • dyc3
🚥 Pre-merge checks | ✅ 4
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and specifically describes the main change: adding regression tests for mixed list markers across blank lines in markdown.
Description check ✅ Passed The description is well-related to the changeset, providing context, linked issues, and test verification steps.
Linked Issues check ✅ Passed The PR adds regression tests that directly address both issues #9729 and #9731 by verifying separate list generation when delimiters/markers change across blank lines.
Out of Scope Changes check ✅ Passed Changes are tightly scoped—only adding two new test cases to verify existing parser behaviour with no unrelated modifications.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-Parser Area: parser L-Markdown Language: Markdown

Projects

None yet

Development

Successfully merging this pull request may close these issues.

🐛 Bullet lists merge across blank lines when marker changes 🐛 Ordered lists merge across blank lines when delimiter changes

2 participants