Skip to content

test(cli): add compact JSON reporter file regression coverage#9664

Closed
raashish1601 wants to merge 1 commit intobiomejs:mainfrom
raashish1601:contributor-61/json-reporter-file-regression
Closed

test(cli): add compact JSON reporter file regression coverage#9664
raashish1601 wants to merge 1 commit intobiomejs:mainfrom
raashish1601:contributor-61/json-reporter-file-regression

Conversation

@raashish1601
Copy link
Copy Markdown

Summary

Testing

  • git diff --check
  • cargo test -p biome_cli reports_diagnostics_json_compact_check_command_file -- --exact (fails in this environment: the Rust toolchain first hit disk-pressure during dependency builds, then a compiler allocation failure on retry)

@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Mar 29, 2026

⚠️ No Changeset found

Latest commit: 1790b18

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added the A-CLI Area: CLI label Mar 29, 2026
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Mar 29, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 64a16e84-9fc7-414b-9537-3b7244dec1af

📥 Commits

Reviewing files that changed from the base of the PR and between c17e08e and 1790b18.

⛔ Files ignored due to path filters (1)
  • crates/biome_cli/tests/snapshots/main_cases_reporter_json/reports_diagnostics_json_compact_check_command_file.snap is excluded by !**/*.snap and included by **
📒 Files selected for processing (1)
  • crates/biome_cli/tests/cases/reporter_json.rs

Walkthrough

A new CLI snapshot test was added to verify the check command with --reporter=json and --reporter-file=file.json flags. The test processes two in-memory TypeScript files, asserts an error result, and captures the snapshot of combined filesystem, console, and output data. No existing tests or implementation logic were modified.

Possibly related PRs

Suggested labels

A-CLI

Suggested reviewers

  • Netail
  • dyc3
🚥 Pre-merge checks | ✅ 2
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately describes the main change: adding a regression test for the compact JSON reporter with file output.
Description check ✅ Passed The description clearly relates to the changeset, explaining the regression coverage being added and the specific issue it addresses.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@Conaclos Conaclos added the M-Likely Agent This was likely an automated PR without a human in the loop label Mar 29, 2026
@ematipico ematipico closed this Mar 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-CLI Area: CLI M-Likely Agent This was likely an automated PR without a human in the loop

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants