Skip to content

fix(core): astro embedding detection#9605

Merged
ematipico merged 2 commits intomainfrom
fix/astro-analyzer
Mar 23, 2026
Merged

fix(core): astro embedding detection#9605
ematipico merged 2 commits intomainfrom
fix/astro-analyzer

Conversation

@ematipico
Copy link
Member

Summary

Closes #9589

Test Plan

Added new tests based on the report

Docs

@ematipico ematipico requested review from a team March 23, 2026 08:38
@changeset-bot
Copy link

changeset-bot bot commented Mar 23, 2026

🦋 Changeset detected

Latest commit: 7101709

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 13 packages
Name Type
@biomejs/biome Patch
@biomejs/cli-win32-x64 Patch
@biomejs/cli-win32-arm64 Patch
@biomejs/cli-darwin-x64 Patch
@biomejs/cli-darwin-arm64 Patch
@biomejs/cli-linux-x64 Patch
@biomejs/cli-linux-arm64 Patch
@biomejs/cli-linux-x64-musl Patch
@biomejs/cli-linux-arm64-musl Patch
@biomejs/wasm-web Patch
@biomejs/wasm-bundler Patch
@biomejs/wasm-nodejs Patch
@biomejs/backend-jsonrpc Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added A-Project Area: project A-Linter Area: linter L-JavaScript Language: JavaScript and super languages labels Mar 23, 2026
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Mar 23, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: be87473d-7714-4c6f-aaab-55045c06b70a

📥 Commits

Reviewing files that changed from the base of the PR and between 7b7c55b and 7101709.

📒 Files selected for processing (1)
  • crates/biome_service/src/embed/types.rs
✅ Files skipped from review due to trivial changes (1)
  • crates/biome_service/src/embed/types.rs

Walkthrough

This change fixes parsing of object expressions inside Astro props and directives by: adding a changeset documenting a patch for issue #9589; adding an Astro test fixture exercising object-literal props and define:vars directive; updating the EmbedCandidate::Directive doc examples to include Astro; and refactoring embedding-kind selection in the HTML file handler so Astro directive embeds are assigned the correct embedding kind.

Possibly related PRs

Suggested labels

A-Parser, L-HTML

Suggested reviewers

  • dyc3
🚥 Pre-merge checks | ✅ 4
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title 'fix(core): astro embedding detection' directly matches the main objective of fixing Astro embedding detection to resolve the lint diagnostic issues.
Description check ✅ Passed The description references the linked issue #9589 and mentions added tests, which aligns with the PR's purpose of fixing Astro embedding detection.
Linked Issues check ✅ Passed The PR implements fixes for the Astro embedding detection issue (#9589) by: updating directive documentation, adding test fixtures for the regression, and refactoring embedding-kind selection logic to explicitly handle Astro hosts. These changes directly address the requirement to fix false-positive lint diagnostics for object-literal props in Astro components.
Out of Scope Changes check ✅ Passed All changes are narrowly focused on Astro embedding detection: documentation updates, test fixtures, and embedding logic refactoring. No unrelated modifications to other systems or features are present.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/astro-analyzer

Comment @coderabbitai help to get the list of available commands and usage tips.

@ematipico ematipico changed the title fix(core): Astro embedding detection fix(core): astro embedding detection Mar 23, 2026
@ematipico ematipico merged commit f65c637 into main Mar 23, 2026
13 of 14 checks passed
@ematipico ematipico deleted the fix/astro-analyzer branch March 23, 2026 09:49
This was referenced Mar 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-Linter Area: linter A-Project Area: project L-JavaScript Language: JavaScript and super languages

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Astro: multiple new lint errrors from v2.4.7 or newer

2 participants