Skip to content

revert: feat(biome_html_analyze): port noRedundantRoles a11y rule to HTML#9587

Merged
dyc3 merged 1 commit intonextfrom
revert-9564-port-no-redundant-roles-html-v2
Mar 22, 2026
Merged

revert: feat(biome_html_analyze): port noRedundantRoles a11y rule to HTML#9587
dyc3 merged 1 commit intonextfrom
revert-9564-port-no-redundant-roles-html-v2

Conversation

@dyc3
Copy link
Contributor

@dyc3 dyc3 commented Mar 22, 2026

Reverts #9564

I just realized this was a duplicate PR. The original was #9276, which is higher quality

I think it was an openclaw bot that filed #9564

@changeset-bot
Copy link

changeset-bot bot commented Mar 22, 2026

⚠️ No Changeset found

Latest commit: 7b81a91

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added A-CLI Area: CLI A-Linter Area: linter L-HTML Language: HTML and super languages labels Mar 22, 2026
@codspeed-hq
Copy link

codspeed-hq bot commented Mar 22, 2026

Merging this PR will degrade performance by 22.21%

❌ 1 regressed benchmark
✅ 63 untouched benchmarks
⏩ 152 skipped benchmarks1

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Benchmark BASE HEAD Efficiency
html_analyzer[index_1033418810622582172.html] 442.6 µs 568.9 µs -22.21%

Comparing revert-9564-port-no-redundant-roles-html-v2 (7b81a91) with next (0e0dbdf)

Open in CodSpeed

Footnotes

  1. 152 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Mar 22, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: e1f6bbe4-62a9-4574-8e14-9e77aad30f0c

📥 Commits

Reviewing files that changed from the base of the PR and between 0e0dbdf and 7b81a91.

⛔ Files ignored due to path filters (9)
  • crates/biome_cli/src/execute/migrate/eslint_any_rule_to_biome.rs is excluded by !**/migrate/eslint_any_rule_to_biome.rs and included by **
  • crates/biome_html_analyze/tests/specs/a11y/noRedundantRoles/astro/invalid.astro.snap is excluded by !**/*.snap and included by **
  • crates/biome_html_analyze/tests/specs/a11y/noRedundantRoles/astro/valid.astro.snap is excluded by !**/*.snap and included by **
  • crates/biome_html_analyze/tests/specs/a11y/noRedundantRoles/invalid.html.snap is excluded by !**/*.snap and included by **
  • crates/biome_html_analyze/tests/specs/a11y/noRedundantRoles/svelte/invalid.svelte.snap is excluded by !**/*.snap and included by **
  • crates/biome_html_analyze/tests/specs/a11y/noRedundantRoles/svelte/valid.svelte.snap is excluded by !**/*.snap and included by **
  • crates/biome_html_analyze/tests/specs/a11y/noRedundantRoles/valid.html.snap is excluded by !**/*.snap and included by **
  • crates/biome_html_analyze/tests/specs/a11y/noRedundantRoles/vue/invalid.vue.snap is excluded by !**/*.snap and included by **
  • crates/biome_html_analyze/tests/specs/a11y/noRedundantRoles/vue/valid.vue.snap is excluded by !**/*.snap and included by **
📒 Files selected for processing (10)
  • .changeset/port-no-redundant-roles-html.md
  • crates/biome_html_analyze/src/lint/a11y/no_redundant_roles.rs
  • crates/biome_html_analyze/tests/specs/a11y/noRedundantRoles/astro/invalid.astro
  • crates/biome_html_analyze/tests/specs/a11y/noRedundantRoles/astro/valid.astro
  • crates/biome_html_analyze/tests/specs/a11y/noRedundantRoles/invalid.html
  • crates/biome_html_analyze/tests/specs/a11y/noRedundantRoles/svelte/invalid.svelte
  • crates/biome_html_analyze/tests/specs/a11y/noRedundantRoles/svelte/valid.svelte
  • crates/biome_html_analyze/tests/specs/a11y/noRedundantRoles/valid.html
  • crates/biome_html_analyze/tests/specs/a11y/noRedundantRoles/vue/invalid.vue
  • crates/biome_html_analyze/tests/specs/a11y/noRedundantRoles/vue/valid.vue
💤 Files with no reviewable changes (10)
  • crates/biome_html_analyze/tests/specs/a11y/noRedundantRoles/vue/valid.vue
  • crates/biome_html_analyze/tests/specs/a11y/noRedundantRoles/svelte/invalid.svelte
  • crates/biome_html_analyze/tests/specs/a11y/noRedundantRoles/svelte/valid.svelte
  • .changeset/port-no-redundant-roles-html.md
  • crates/biome_html_analyze/tests/specs/a11y/noRedundantRoles/valid.html
  • crates/biome_html_analyze/tests/specs/a11y/noRedundantRoles/vue/invalid.vue
  • crates/biome_html_analyze/tests/specs/a11y/noRedundantRoles/invalid.html
  • crates/biome_html_analyze/tests/specs/a11y/noRedundantRoles/astro/valid.astro
  • crates/biome_html_analyze/tests/specs/a11y/noRedundantRoles/astro/invalid.astro
  • crates/biome_html_analyze/src/lint/a11y/no_redundant_roles.rs

Walkthrough

This change removes the noRedundantRoles HTML a11y lint rule alongside all associated test fixtures and changeset metadata. The deletion encompasses the complete rule implementation (360 lines) that previously checked for redundant explicit ARIA role attributes on HTML elements across Vue, Svelte, Astro, and standard HTML files, plus all corresponding test cases for valid and invalid scenarios.

Possibly related PRs

Suggested reviewers

  • ematipico
🚥 Pre-merge checks | ✅ 2
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately describes the primary change: reverting PR #9564 which ported the noRedundantRoles rule to HTML.
Description check ✅ Passed The description directly explains the changeset's purpose: reverting a duplicate PR in favour of the higher-quality original.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch revert-9564-port-no-redundant-roles-html-v2

Comment @coderabbitai help to get the list of available commands and usage tips.

Tip

CodeRabbit can use Trivy to scan for security misconfigurations and secrets in Infrastructure as Code files.

Add a .trivyignore file to your project to customize which findings Trivy reports.

@dyc3 dyc3 merged commit 3284367 into next Mar 22, 2026
16 of 17 checks passed
@dyc3 dyc3 deleted the revert-9564-port-no-redundant-roles-html-v2 branch March 22, 2026 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-CLI Area: CLI A-Linter Area: linter L-HTML Language: HTML and super languages

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant