Skip to content

fix(noSubstr): query more nodes#9538

Merged
ematipico merged 1 commit intomainfrom
fix/rule-substr
Mar 18, 2026
Merged

fix(noSubstr): query more nodes#9538
ematipico merged 1 commit intomainfrom
fix/rule-substr

Conversation

@ematipico
Copy link
Member

Summary

Closes #9279

The rule queried the wrong nodes. With better nodes, now we can detect more cases. Fix created with the help of Claude Code.

Test Plan

Added new test cases

Docs

@ematipico ematipico requested review from a team March 18, 2026 08:34
@changeset-bot
Copy link

changeset-bot bot commented Mar 18, 2026

🦋 Changeset detected

Latest commit: 8dc47af

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 13 packages
Name Type
@biomejs/biome Patch
@biomejs/cli-win32-x64 Patch
@biomejs/cli-win32-arm64 Patch
@biomejs/cli-darwin-x64 Patch
@biomejs/cli-darwin-arm64 Patch
@biomejs/cli-linux-x64 Patch
@biomejs/cli-linux-arm64 Patch
@biomejs/cli-linux-x64-musl Patch
@biomejs/cli-linux-arm64-musl Patch
@biomejs/wasm-web Patch
@biomejs/wasm-bundler Patch
@biomejs/wasm-nodejs Patch
@biomejs/backend-jsonrpc Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added A-Linter Area: linter L-JavaScript Language: JavaScript and super languages labels Mar 18, 2026
@codspeed-hq
Copy link

codspeed-hq bot commented Mar 18, 2026

Merging this PR will not alter performance

✅ 58 untouched benchmarks
⏩ 156 skipped benchmarks1


Comparing fix/rule-substr (8dc47af) with main (1302740)2

Open in CodSpeed

Footnotes

  1. 156 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

  2. No successful run was found on main (c23272c) during the generation of this report, so 1302740 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report.

@ematipico ematipico merged commit 794f79c into main Mar 18, 2026
18 checks passed
@ematipico ematipico deleted the fix/rule-substr branch March 18, 2026 10:43
@github-actions github-actions bot mentioned this pull request Mar 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-Linter Area: linter L-JavaScript Language: JavaScript and super languages

Projects

None yet

Development

Successfully merging this pull request may close these issues.

💅 noSubstr not detecting errors on variable usage

3 participants