Skip to content

chore: manually import dev dependencies#9512

Merged
ematipico merged 2 commits intomainfrom
chore/dev-deps
Mar 16, 2026
Merged

chore: manually import dev dependencies#9512
ematipico merged 2 commits intomainfrom
chore/dev-deps

Conversation

@ematipico
Copy link
Copy Markdown
Member

Summary

This PR refactors the manifests to load internal crates via path inside dev dependencies.

This change should fix an issue where we can't upgrade insta.

Test Plan

Green CI

Docs

@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Mar 16, 2026

⚠️ No Changeset found

Latest commit: 7491b8d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@ematipico ematipico requested review from a team March 16, 2026 12:59
@github-actions github-actions bot added A-CLI Area: CLI A-Project Area: project A-Linter Area: linter A-Parser Area: parser A-Formatter Area: formatter L-JavaScript Language: JavaScript and super languages L-CSS Language: CSS and super languages L-JSON Language: JSON and super languages L-HTML Language: HTML and super languages L-Grit Language: GritQL A-Type-Inference Area: type inference L-Tailwind Language: Tailwind CSS L-Markdown Language: Markdown L-Yaml Language: Yaml labels Mar 16, 2026
@github-actions
Copy link
Copy Markdown
Contributor

Parser conformance results on

js/262

Test result main count This PR count Difference
Total 53139 53139 0
Passed 51919 51919 0
Failed 1178 1178 0
Panics 42 42 0
Coverage 97.70% 97.70% 0.00%

jsx/babel

Test result main count This PR count Difference
Total 38 38 0
Passed 37 37 0
Failed 1 1 0
Panics 0 0 0
Coverage 97.37% 97.37% 0.00%

markdown/commonmark

Test result main count This PR count Difference
Total 652 652 0
Passed 652 652 0
Failed 0 0 0
Panics 0 0 0
Coverage 100.00% 100.00% 0.00%

symbols/microsoft

Test result main count This PR count Difference
Total 5466 5466 0
Passed 1915 1915 0
Failed 3551 3551 0
Panics 0 0 0
Coverage 35.03% 35.03% 0.00%

ts/babel

Test result main count This PR count Difference
Total 636 636 0
Passed 568 568 0
Failed 68 68 0
Panics 0 0 0
Coverage 89.31% 89.31% 0.00%

ts/microsoft

Test result main count This PR count Difference
Total 18875 18875 0
Passed 13014 13014 0
Failed 5860 5860 0
Panics 1 1 0
Coverage 68.95% 68.95% 0.00%

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Mar 16, 2026

Walkthrough

This PR systematically updates dev-dependency declarations across multiple Biome crates from workspace = true to explicit relative path references (e.g., path = "../biome_formatter"). It also adds documentation guidance in SKILL.md, AGENTS.md, and CONTRIBUTING.md clarifying that internal biome crates use workspace dependencies in [dependencies] but must use path references in [dev-dependencies]. Changes span approximately 20+ Cargo.toml files across various crates including biome_cli, biome_html_formatter, biome_js_parser, and biome_json_formatter.

Possibly related PRs

Suggested labels

A-Tooling, A-Project

Suggested reviewers

  • dyc3
🚥 Pre-merge checks | ✅ 2
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately describes the main change: converting dev dependencies from workspace references to manual path imports across multiple Cargo.toml files.
Description check ✅ Passed The description clearly explains the purpose of the changes: refactoring manifests to load internal crates via path in dev dependencies to fix an insta upgrade blocker.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch chore/dev-deps
📝 Coding Plan
  • Generate coding plan for human review comments

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (1)
crates/biome_html_formatter/Cargo.toml (1)

30-42: ⚠️ Potential issue | 🟡 Minor

Use a path dependency for tests_macros to match the other internal dev-dependencies.

Line 42 uses workspace = true while the other internal dev-dependencies earlier in this section use path dependencies. For dev-dependencies, path dependencies should be used to avoid requiring published versions.

Suggested patch
- tests_macros         = { workspace = true }
+ tests_macros         = { path = "../tests_macros" }
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In `@crates/biome_html_formatter/Cargo.toml` around lines 30 - 42, The
dev-dependency entry for tests_macros uses workspace = true but should be a path
dependency like the other internal dev-dependencies; update the tests_macros
entry in Cargo.toml to use a path = "../tests_macros" (matching the pattern used
by biome_configuration, biome_formatter_test, etc.) so it is referenced via a
local path rather than workspace = true.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Outside diff comments:
In `@crates/biome_html_formatter/Cargo.toml`:
- Around line 30-42: The dev-dependency entry for tests_macros uses workspace =
true but should be a path dependency like the other internal dev-dependencies;
update the tests_macros entry in Cargo.toml to use a path = "../tests_macros"
(matching the pattern used by biome_configuration, biome_formatter_test, etc.)
so it is referenced via a local path rather than workspace = true.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 3fa86c21-285d-4b74-95b8-d0c02c363378

📥 Commits

Reviewing files that changed from the base of the PR and between c311974 and 7491b8d.

📒 Files selected for processing (26)
  • .claude/skills/biome-developer/SKILL.md
  • AGENTS.md
  • CONTRIBUTING.md
  • crates/biome_cli/Cargo.toml
  • crates/biome_css_analyze/Cargo.toml
  • crates/biome_css_formatter/Cargo.toml
  • crates/biome_deserialize/Cargo.toml
  • crates/biome_graphql_parser/Cargo.toml
  • crates/biome_grit_parser/Cargo.toml
  • crates/biome_html_formatter/Cargo.toml
  • crates/biome_html_parser/Cargo.toml
  • crates/biome_js_analyze/Cargo.toml
  • crates/biome_js_formatter/Cargo.toml
  • crates/biome_js_parser/Cargo.toml
  • crates/biome_js_type_info/Cargo.toml
  • crates/biome_json_analyze/Cargo.toml
  • crates/biome_json_formatter/Cargo.toml
  • crates/biome_json_parser/Cargo.toml
  • crates/biome_json_value/Cargo.toml
  • crates/biome_markdown_formatter/Cargo.toml
  • crates/biome_module_graph/Cargo.toml
  • crates/biome_plugin_loader/Cargo.toml
  • crates/biome_service/Cargo.toml
  • crates/biome_tailwind_parser/Cargo.toml
  • crates/biome_yaml_formatter/Cargo.toml
  • crates/biome_yaml_parser/Cargo.toml

@ematipico ematipico merged commit 9315453 into main Mar 16, 2026
14 checks passed
@ematipico ematipico deleted the chore/dev-deps branch March 16, 2026 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-CLI Area: CLI A-Formatter Area: formatter A-Linter Area: linter A-Parser Area: parser A-Project Area: project A-Type-Inference Area: type inference L-CSS Language: CSS and super languages L-Grit Language: GritQL L-HTML Language: HTML and super languages L-JavaScript Language: JavaScript and super languages L-JSON Language: JSON and super languages L-Markdown Language: Markdown L-Tailwind Language: Tailwind CSS L-Yaml Language: Yaml

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant