Conversation
|
Parser conformance results onjs/262
jsx/babel
markdown/commonmark
symbols/microsoft
ts/babel
ts/microsoft
|
WalkthroughThis PR systematically updates dev-dependency declarations across multiple Biome crates from Possibly related PRs
Suggested labels
Suggested reviewers
🚥 Pre-merge checks | ✅ 2✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
📝 Coding Plan
Comment |
There was a problem hiding this comment.
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
crates/biome_html_formatter/Cargo.toml (1)
30-42:⚠️ Potential issue | 🟡 MinorUse a path dependency for
tests_macrosto match the other internal dev-dependencies.Line 42 uses
workspace = truewhile the other internal dev-dependencies earlier in this section use path dependencies. For dev-dependencies, path dependencies should be used to avoid requiring published versions.Suggested patch
- tests_macros = { workspace = true } + tests_macros = { path = "../tests_macros" }🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@crates/biome_html_formatter/Cargo.toml` around lines 30 - 42, The dev-dependency entry for tests_macros uses workspace = true but should be a path dependency like the other internal dev-dependencies; update the tests_macros entry in Cargo.toml to use a path = "../tests_macros" (matching the pattern used by biome_configuration, biome_formatter_test, etc.) so it is referenced via a local path rather than workspace = true.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Outside diff comments:
In `@crates/biome_html_formatter/Cargo.toml`:
- Around line 30-42: The dev-dependency entry for tests_macros uses workspace =
true but should be a path dependency like the other internal dev-dependencies;
update the tests_macros entry in Cargo.toml to use a path = "../tests_macros"
(matching the pattern used by biome_configuration, biome_formatter_test, etc.)
so it is referenced via a local path rather than workspace = true.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 3fa86c21-285d-4b74-95b8-d0c02c363378
📒 Files selected for processing (26)
.claude/skills/biome-developer/SKILL.mdAGENTS.mdCONTRIBUTING.mdcrates/biome_cli/Cargo.tomlcrates/biome_css_analyze/Cargo.tomlcrates/biome_css_formatter/Cargo.tomlcrates/biome_deserialize/Cargo.tomlcrates/biome_graphql_parser/Cargo.tomlcrates/biome_grit_parser/Cargo.tomlcrates/biome_html_formatter/Cargo.tomlcrates/biome_html_parser/Cargo.tomlcrates/biome_js_analyze/Cargo.tomlcrates/biome_js_formatter/Cargo.tomlcrates/biome_js_parser/Cargo.tomlcrates/biome_js_type_info/Cargo.tomlcrates/biome_json_analyze/Cargo.tomlcrates/biome_json_formatter/Cargo.tomlcrates/biome_json_parser/Cargo.tomlcrates/biome_json_value/Cargo.tomlcrates/biome_markdown_formatter/Cargo.tomlcrates/biome_module_graph/Cargo.tomlcrates/biome_plugin_loader/Cargo.tomlcrates/biome_service/Cargo.tomlcrates/biome_tailwind_parser/Cargo.tomlcrates/biome_yaml_formatter/Cargo.tomlcrates/biome_yaml_parser/Cargo.toml
Summary
This PR refactors the manifests to load internal crates via path inside dev dependencies.
This change should fix an issue where we can't upgrade insta.
Test Plan
Green CI
Docs