Skip to content

fix: compilation issue due to merge#9442

Merged
ematipico merged 1 commit intomainfrom
fix/compilation-fail
Mar 11, 2026
Merged

fix: compilation issue due to merge#9442
ematipico merged 1 commit intomainfrom
fix/compilation-fail

Conversation

@ematipico
Copy link
Member

Summary

main is failing due to a compilation issue. This fixes it

Test Plan

Docs

@changeset-bot
Copy link

changeset-bot bot commented Mar 11, 2026

⚠️ No Changeset found

Latest commit: 02de86f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added A-Linter Area: linter L-CSS Language: CSS and super languages labels Mar 11, 2026
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Mar 11, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 41b0f330-08b2-45c1-8aac-8d08027cc3d1

📥 Commits

Reviewing files that changed from the base of the PR and between 3ac98eb and 02de86f.

📒 Files selected for processing (1)
  • crates/biome_css_analyze/src/lint/nursery/use_baseline.rs

Walkthrough

This change extends SCSS at-rule support in the baseline linting logic by adding twelve additional SCSS at-rule variants to the pattern-matching logic. The variants—including content, debug, each, error, for, function, if, include, mixin, return, warn, and while at-rules—are now recognised during at-rule name resolution and baseline lookups. The implementation treats these new variants consistently with existing at-rules, with no modifications to error handling or public API signatures.

🚥 Pre-merge checks | ✅ 2
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title directly addresses the changeset, which fixes a compilation issue caused by a merge by expanding SCSS at-rule recognition.
Description check ✅ Passed The description states the PR fixes a compilation failure on main, which aligns with the changeset's purpose of resolving merge-related compilation issues.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
  • 📝 Generate docstrings (stacked PR)
  • 📝 Generate docstrings (commit on current branch)
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch fix/compilation-fail

Comment @coderabbitai help to get the list of available commands and usage tips.

@ematipico ematipico merged commit 8475d90 into main Mar 11, 2026
16 checks passed
@ematipico ematipico deleted the fix/compilation-fail branch March 11, 2026 08:55
@codspeed-hq
Copy link

codspeed-hq bot commented Mar 11, 2026

Merging this PR will not alter performance

✅ 29 untouched benchmarks
⏩ 187 skipped benchmarks1


Comparing fix/compilation-fail (02de86f) with main (3ac98eb)

Open in CodSpeed

Footnotes

  1. 187 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@dyc3
Copy link
Contributor

dyc3 commented Mar 11, 2026

another reason i wish we could use the merge queue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-Linter Area: linter L-CSS Language: CSS and super languages

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants