ci: publish to pkg pr new before disatpch event#9439
Conversation
|
WalkthroughThis release workflow update refactors WASM and Docker image publishing. It introduces a new Possibly related PRs
Suggested reviewers
🚥 Pre-merge checks | ✅ 2✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
🧹 Nitpick comments (2)
.github/workflows/release.yml (2)
449-456: Thecache: pnpmsetting is not utilised here.Since this job doesn't run
pnpm install, the cache won't provide any benefit. The setup order is also reversed compared to the rest of the file (pnpm is installed beforeactions/setup-node).Consider either removing
cache: pnpmor aligning with the pattern used in other jobs.♻️ Suggested simplification
- name: Install pnpm run: npm i -g --force corepack && corepack enable - name: Setup node uses: actions/setup-node@6044e13b5dc448c55e2357c09f80417699197238 # v6.2.0 with: node-version: 24.13.1 - cache: pnpm🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In @.github/workflows/release.yml around lines 449 - 456, The workflow currently installs pnpm before the actions/setup-node step and includes the unused setting cache: pnpm; update the steps so they match other jobs: either remove the cache: pnpm line entirely if this job never runs pnpm install, or move the "Install pnpm" step to after the "Setup node" step and keep cache: pnpm (and ensure a pnpm install step exists) so the cache is actually used; refer to the step names "Install pnpm" and "Setup node" and the setting "cache: pnpm" when making the change.
432-432: Custom runner label flagged by static analysis.The label
depot-ubuntu-24.04-arm-smallis not a standard GitHub-hosted runner. While it's used elsewhere in this workflow (consistent with Depot runners), you may want to add anactionlint.yamlconfig to suppress this warning.🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In @.github/workflows/release.yml at line 432, Static analysis flags the non-standard runner label "depot-ubuntu-24.04-arm-small" used in the runs-on line; add an actionlint config to permit that custom label by creating an actionlint.yaml at repo root that either whitelists the runner label (e.g., add the exact "depot-ubuntu-24.04-arm-small" value to the allowed runners/patterns) or disables the runner-label check for this workflow; update the config so actionlint no longer reports the runs-on value as invalid while leaving other validations enabled.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In @.github/workflows/release.yml:
- Around line 449-456: The workflow currently installs pnpm before the
actions/setup-node step and includes the unused setting cache: pnpm; update the
steps so they match other jobs: either remove the cache: pnpm line entirely if
this job never runs pnpm install, or move the "Install pnpm" step to after the
"Setup node" step and keep cache: pnpm (and ensure a pnpm install step exists)
so the cache is actually used; refer to the step names "Install pnpm" and "Setup
node" and the setting "cache: pnpm" when making the change.
- Line 432: Static analysis flags the non-standard runner label
"depot-ubuntu-24.04-arm-small" used in the runs-on line; add an actionlint
config to permit that custom label by creating an actionlint.yaml at repo root
that either whitelists the runner label (e.g., add the exact
"depot-ubuntu-24.04-arm-small" value to the allowed runners/patterns) or
disables the runner-label check for this workflow; update the config so
actionlint no longer reports the runs-on value as invalid while leaving other
validations enabled.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 47f337a5-fef3-4e99-ba46-80b672173231
📒 Files selected for processing (1)
.github/workflows/release.yml
Summary
This PR updated the release workflow:
continue-on-error: truestep so it doesn't interfere with what we have today.Test Plan
Proof reading. The Github diff is weird.
Docs