Skip to content

ci: publish to pkg pr new before disatpch event#9439

Merged
ematipico merged 1 commit intomainfrom
ci/publish-pkg-before-event
Mar 11, 2026
Merged

ci: publish to pkg pr new before disatpch event#9439
ematipico merged 1 commit intomainfrom
ci/publish-pkg-before-event

Conversation

@ematipico
Copy link
Member

Summary

This PR updated the release workflow:

  • After the WASM build and the publish CLI, we have a new step that downloads the WASM web distribution and publishes it to pkg.pr.new (code copied from the dispatch workflow), it then dispatches the same event that was dispatched by the publish CLI step. I set the continue-on-error: true step so it doesn't interfere with what we have today.
  • The publish CLI step doesn't dispatch any event
  • The publish CLI step now forwards the release version, so that it can be used in the new step

Test Plan

Proof reading. The Github diff is weird.

Docs

@changeset-bot
Copy link

changeset-bot bot commented Mar 10, 2026

⚠️ No Changeset found

Latest commit: a2e6655

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@ematipico ematipico requested review from a team March 10, 2026 18:44
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Mar 10, 2026

Walkthrough

This release workflow update refactors WASM and Docker image publishing. It introduces a new publish-wasm-web job that independently publishes WASM artifacts to pkg-pr-new and triggers website repository updates. Docker image generation now targets the dedicated Docker repository rather than the website repository. A version output is added to the publish-cli job to propagate downstream, and repository dispatch steps are adjusted to route events to their appropriate targets with corresponding payloads.

Possibly related PRs

Suggested reviewers

  • siketyan
  • dyc3
🚥 Pre-merge checks | ✅ 2
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title references publishing to pkg pr new before dispatching an event, which aligns with the main change of adding a new wasm-web publish step before dispatching.
Description check ✅ Passed The description clearly explains the workflow updates: adding a new wasm-web publication step, removing dispatch from publish-cli, and forwarding the version output.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch ci/publish-pkg-before-event

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick comments (2)
.github/workflows/release.yml (2)

449-456: The cache: pnpm setting is not utilised here.

Since this job doesn't run pnpm install, the cache won't provide any benefit. The setup order is also reversed compared to the rest of the file (pnpm is installed before actions/setup-node).

Consider either removing cache: pnpm or aligning with the pattern used in other jobs.

♻️ Suggested simplification
      - name: Install pnpm
        run: npm i -g --force corepack && corepack enable

      - name: Setup node
        uses: actions/setup-node@6044e13b5dc448c55e2357c09f80417699197238 # v6.2.0
        with:
          node-version: 24.13.1
-          cache: pnpm
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In @.github/workflows/release.yml around lines 449 - 456, The workflow currently
installs pnpm before the actions/setup-node step and includes the unused setting
cache: pnpm; update the steps so they match other jobs: either remove the cache:
pnpm line entirely if this job never runs pnpm install, or move the "Install
pnpm" step to after the "Setup node" step and keep cache: pnpm (and ensure a
pnpm install step exists) so the cache is actually used; refer to the step names
"Install pnpm" and "Setup node" and the setting "cache: pnpm" when making the
change.

432-432: Custom runner label flagged by static analysis.

The label depot-ubuntu-24.04-arm-small is not a standard GitHub-hosted runner. While it's used elsewhere in this workflow (consistent with Depot runners), you may want to add an actionlint.yaml config to suppress this warning.

🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In @.github/workflows/release.yml at line 432, Static analysis flags the
non-standard runner label "depot-ubuntu-24.04-arm-small" used in the runs-on
line; add an actionlint config to permit that custom label by creating an
actionlint.yaml at repo root that either whitelists the runner label (e.g., add
the exact "depot-ubuntu-24.04-arm-small" value to the allowed runners/patterns)
or disables the runner-label check for this workflow; update the config so
actionlint no longer reports the runs-on value as invalid while leaving other
validations enabled.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Nitpick comments:
In @.github/workflows/release.yml:
- Around line 449-456: The workflow currently installs pnpm before the
actions/setup-node step and includes the unused setting cache: pnpm; update the
steps so they match other jobs: either remove the cache: pnpm line entirely if
this job never runs pnpm install, or move the "Install pnpm" step to after the
"Setup node" step and keep cache: pnpm (and ensure a pnpm install step exists)
so the cache is actually used; refer to the step names "Install pnpm" and "Setup
node" and the setting "cache: pnpm" when making the change.
- Line 432: Static analysis flags the non-standard runner label
"depot-ubuntu-24.04-arm-small" used in the runs-on line; add an actionlint
config to permit that custom label by creating an actionlint.yaml at repo root
that either whitelists the runner label (e.g., add the exact
"depot-ubuntu-24.04-arm-small" value to the allowed runners/patterns) or
disables the runner-label check for this workflow; update the config so
actionlint no longer reports the runs-on value as invalid while leaving other
validations enabled.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 47f337a5-fef3-4e99-ba46-80b672173231

📥 Commits

Reviewing files that changed from the base of the PR and between 73205b9 and a2e6655.

📒 Files selected for processing (1)
  • .github/workflows/release.yml

@ematipico ematipico merged commit 71a19b9 into main Mar 11, 2026
3 checks passed
@ematipico ematipico deleted the ci/publish-pkg-before-event branch March 11, 2026 05:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants