You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The CSS grammar had grown enough SCSS and at-rule support that it exceeded the fixed SyntaxKindSet capacity in biome_rowan. We have another option: #9436
Test Plan
cargo test -p biome_css_parser
cargo test -p biome_css_formatter
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
This PR includes no changesets
When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types
The SyntaxKindSet struct in biome_rowan expands its internal bitfield storage from a 5-element u128 array to 6 elements. This increases the capacity of the syntax kind set to accommodate additional syntax kinds. The from_raw and union methods are updated accordingly to handle the expanded array dimension, with documentation examples adjusted to reflect the larger capacity.
The title accurately describes the main change: expanding SyntaxKindSet's bitfield from 5 to 6 elements for extended node support.
Description check
✅ Passed
The PR description clearly explains the reason for the change (CSS grammar growth exceeded capacity) and provides a test plan, directly relating to the bitfield expansion in the changeset.
✏️ Tip: You can configure your own custom pre-merge checks in the settings.
✨ Finishing Touches🧪 Generate unit tests (beta)
Create PR with unit tests
Post copyable unit tests in a comment
Commit unit tests in branch db/extend
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The CSS grammar had grown enough SCSS and at-rule support that it exceeded the fixed
SyntaxKindSetcapacity inbiome_rowan. We have another option: #9436Test Plan
cargo test -p biome_css_parser
cargo test -p biome_css_formatter