Skip to content

feat(ast): increase SyntaxKindSet bitfield size to 6 elements for extended node support#9438

Merged
denbezrukov merged 1 commit intomainfrom
db/extend
Mar 10, 2026
Merged

feat(ast): increase SyntaxKindSet bitfield size to 6 elements for extended node support#9438
denbezrukov merged 1 commit intomainfrom
db/extend

Conversation

@denbezrukov
Copy link
Contributor

@denbezrukov denbezrukov commented Mar 10, 2026

Summary

The CSS grammar had grown enough SCSS and at-rule support that it exceeded the fixed SyntaxKindSet capacity in biome_rowan. We have another option: #9436

Test Plan

cargo test -p biome_css_parser
cargo test -p biome_css_formatter

@changeset-bot
Copy link

changeset-bot bot commented Mar 10, 2026

⚠️ No Changeset found

Latest commit: 4e4c3d4

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added the A-Core Area: core label Mar 10, 2026
@codspeed-hq
Copy link

codspeed-hq bot commented Mar 10, 2026

Merging this PR will not alter performance

✅ 58 untouched benchmarks
⏩ 156 skipped benchmarks1


Comparing db/extend (4e4c3d4) with main (795bad4)

Open in CodSpeed

Footnotes

  1. 156 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@github-actions
Copy link
Contributor

Parser conformance results on

js/262

Test result main count This PR count Difference
Total 53078 53078 0
Passed 51858 51858 0
Failed 1178 1178 0
Panics 42 42 0
Coverage 97.70% 97.70% 0.00%

jsx/babel

Test result main count This PR count Difference
Total 38 38 0
Passed 37 37 0
Failed 1 1 0
Panics 0 0 0
Coverage 97.37% 97.37% 0.00%

markdown/commonmark

Test result main count This PR count Difference
Total 652 652 0
Passed 652 652 0
Failed 0 0 0
Panics 0 0 0
Coverage 100.00% 100.00% 0.00%

symbols/microsoft

Test result main count This PR count Difference
Total 5466 5466 0
Passed 1915 1915 0
Failed 3551 3551 0
Panics 0 0 0
Coverage 35.03% 35.03% 0.00%

ts/babel

Test result main count This PR count Difference
Total 636 636 0
Passed 568 568 0
Failed 68 68 0
Panics 0 0 0
Coverage 89.31% 89.31% 0.00%

ts/microsoft

Test result main count This PR count Difference
Total 18875 18875 0
Passed 13014 13014 0
Failed 5860 5860 0
Panics 1 1 0
Coverage 68.95% 68.95% 0.00%

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Mar 10, 2026

Walkthrough

The SyntaxKindSet struct in biome_rowan expands its internal bitfield storage from a 5-element u128 array to 6 elements. This increases the capacity of the syntax kind set to accommodate additional syntax kinds. The from_raw and union methods are updated accordingly to handle the expanded array dimension, with documentation examples adjusted to reflect the larger capacity.

Possibly related PRs

Suggested labels

A-Core

Suggested reviewers

  • ematipico
🚥 Pre-merge checks | ✅ 2
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately describes the main change: expanding SyntaxKindSet's bitfield from 5 to 6 elements for extended node support.
Description check ✅ Passed The PR description clearly explains the reason for the change (CSS grammar growth exceeded capacity) and provides a test plan, directly relating to the bitfield expansion in the changeset.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch db/extend

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@denbezrukov
Copy link
Contributor Author

If it doesn't alter performance, I prefer this change

@denbezrukov denbezrukov merged commit 73205b9 into main Mar 10, 2026
35 checks passed
@denbezrukov denbezrukov deleted the db/extend branch March 10, 2026 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-Core Area: core

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants