Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(ja): translate vscode into Japanese #938

Merged
merged 10 commits into from
Nov 29, 2023

Conversation

sakimyto
Copy link
Contributor

Summary

Partial work of #880 .

  • translated ja/reference/vscode.mdx.
  • fixed to settings.json instead of biome.json in reference/vscode.mdx.
    • let me know if you'd prefer to separate the PRs.

Test Plan

@sakimyto sakimyto requested a review from a team as a code owner November 28, 2023 13:41
@github-actions github-actions bot added the A-Website Area: website label Nov 28, 2023
Copy link
Member

@unvalley unvalley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! I left some suggestions but they are nits. We need to update some sentences on the original doc. If you have time, I would like to have it done:)

website/src/content/docs/ja/reference/vscode.mdx Outdated Show resolved Hide resolved
website/src/content/docs/ja/reference/vscode.mdx Outdated Show resolved Hide resolved
website/src/content/docs/ja/reference/vscode.mdx Outdated Show resolved Hide resolved
website/src/content/docs/ja/reference/vscode.mdx Outdated Show resolved Hide resolved
@sakimyto
Copy link
Contributor Author

@unvalley
Thank you for your reviews.

Thank you! I left some suggestions but they are nits. We need to update some sentences on the original doc. If you have time, I would like to have it done:)

Is this right?

93522c3

@unvalley
Copy link
Member

@sakimyto Yes, Thanks!

@unvalley unvalley merged commit 4a88605 into biomejs:main Nov 29, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Website Area: website
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants