Skip to content

feat(config): expose html.parser.vue#9366

Open
dyc3 wants to merge 3 commits intonextfrom
dyc3/html-parser-vue-config
Open

feat(config): expose html.parser.vue#9366
dyc3 wants to merge 3 commits intonextfrom
dyc3/html-parser-vue-config

Conversation

@dyc3
Copy link
Copy Markdown
Contributor

@dyc3 dyc3 commented Mar 6, 2026

Summary

This option was supposed to be exposed, and is referenced in error messages, but it was not exposed.

Test Plan

added cli tests

Docs

@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Mar 6, 2026

🦋 Changeset detected

Latest commit: 41db234

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 14 packages
Name Type
@biomejs/biome Minor
@biomejs/js-api Major
@biomejs/cli-win32-x64 Minor
@biomejs/cli-win32-arm64 Minor
@biomejs/cli-darwin-x64 Minor
@biomejs/cli-darwin-arm64 Minor
@biomejs/cli-linux-x64 Minor
@biomejs/cli-linux-arm64 Minor
@biomejs/cli-linux-x64-musl Minor
@biomejs/cli-linux-arm64-musl Minor
@biomejs/wasm-web Minor
@biomejs/wasm-bundler Minor
@biomejs/wasm-nodejs Minor
@biomejs/backend-jsonrpc Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added A-Project Area: project A-Parser Area: parser L-HTML Language: HTML and super languages labels Mar 6, 2026
@codspeed-hq
Copy link
Copy Markdown

codspeed-hq bot commented Mar 6, 2026

Merging this PR will not alter performance

✅ 64 untouched benchmarks
⏩ 152 skipped benchmarks1


Comparing dyc3/html-parser-vue-config (26d2dd3) with main (cb4d7d7)

Open in CodSpeed

Footnotes

  1. 152 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@dyc3 dyc3 force-pushed the dyc3/html-parser-vue-config branch from 76ac82f to e4b6fea Compare March 6, 2026 12:04
@github-actions github-actions bot added the A-CLI Area: CLI label Mar 6, 2026
@dyc3 dyc3 force-pushed the dyc3/html-parser-vue-config branch from e4b6fea to 0bbda9e Compare March 6, 2026 12:07
@dyc3 dyc3 marked this pull request as ready for review March 6, 2026 12:19
Copy link
Copy Markdown
Member

@ematipico ematipico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would like to have a discussion about the applicability of this option.

I think it's safer to target only .html files, not .astro and .svelte.

However, if we've set on this, we need to document how users can opt out.

Also, there must be a docs PR

Comment thread .changeset/expose-html-parser-vue-option.md Outdated
Comment thread crates/biome_configuration/src/html.rs Outdated
@dyc3 dyc3 added this to the Biome v2.5 milestone Mar 7, 2026
@dyc3 dyc3 force-pushed the dyc3/html-parser-vue-config branch from 26d2dd3 to 41db234 Compare March 22, 2026 17:25
@github-actions github-actions bot added A-Linter Area: linter A-Tooling Area: internal tools A-LSP Area: language server protocol L-JavaScript Language: JavaScript and super languages L-CSS Language: CSS and super languages L-JSON Language: JSON and super languages A-Diagnostic Area: diagnostocis L-Grit Language: GritQL A-Resolver Area: resolver labels Mar 22, 2026
@dyc3 dyc3 changed the base branch from main to next March 22, 2026 17:27
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Mar 22, 2026

Caution

Review failed

Failed to post review comments

Walkthrough

This PR introduces substantial feature additions and improvements across Biome's linting, parsing, and assisting capabilities. Key changes include new CSS and HTML lint rules (noUndeclaredClasses, noUnusedClasses, useBaseline, useImportsFirst, noRedundantRoles), enhanced module graph support enabling cross-file class name validation, a plugin system update supporting code action diagnostics with configurable fix kinds, a new package.json organising assist (useSortedPackageJson), sortBareImports option for organiseImports, HTML parser Vue syntax support, and formatter fixes for embedded templates. Extensive test fixtures validate the new functionality, and documentation standards prohibiting emojis are established across contribution surfaces.

Possibly related PRs

Suggested reviewers

  • ematipico
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch dyc3/html-parser-vue-config

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-CLI Area: CLI A-Diagnostic Area: diagnostocis A-Linter Area: linter A-LSP Area: language server protocol A-Parser Area: parser A-Project Area: project A-Resolver Area: resolver A-Tooling Area: internal tools L-CSS Language: CSS and super languages L-Grit Language: GritQL L-HTML Language: HTML and super languages L-JavaScript Language: JavaScript and super languages L-JSON Language: JSON and super languages

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants