Skip to content

chore: rust 1.94.0#9356

Merged
ematipico merged 2 commits intobiomejs:mainfrom
Netail:feat/rust-1-94-0
Mar 6, 2026
Merged

chore: rust 1.94.0#9356
ematipico merged 2 commits intobiomejs:mainfrom
Netail:feat/rust-1-94-0

Conversation

@Netail
Copy link
Copy Markdown
Member

@Netail Netail commented Mar 5, 2026

Summary

Rust bump

Test Plan

Docs

@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Mar 5, 2026

⚠️ No Changeset found

Latest commit: db6a942

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Mar 5, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 073370a9-eedd-4287-ba3c-3039a67149e4

📥 Commits

Reviewing files that changed from the base of the PR and between ada2b98 and db6a942.

📒 Files selected for processing (2)
  • crates/biome_js_analyze/tests/spec_tests.rs
  • crates/biome_migrate/src/analyzers/includes.rs
💤 Files with no reviewable changes (1)
  • crates/biome_js_analyze/tests/spec_tests.rs

Walkthrough

This PR bumps the Rust toolchain from 1.93.1 to 1.94.0 across the repo: rust-toolchain.toml, CI workflows (.github/workflows/beta.yml, preview.yml, release.yml), and Dockerfile.benchmark. Additionally, it removes a crate-level Clippy expectation in crates/biome_js_analyze/tests/spec_tests.rs and replaces a checked_sub(1).unwrap_or_default() with saturating_sub(1) in crates/biome_migrate/src/analyzers/includes.rs. No API or control-flow changes detected.

Possibly related PRs

Suggested labels

A-Tooling, A-Linter, A-Project

Suggested reviewers

  • ematipico
  • siketyan
🚥 Pre-merge checks | ✅ 2
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately describes the main change: bumping Rust from 1.93.1 to 1.94.0 across all configuration files and workflows.
Description check ✅ Passed The description, whilst minimal, directly relates to the changeset by identifying it as a Rust version bump.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions github-actions bot added A-Linter Area: linter L-JavaScript Language: JavaScript and super languages labels Mar 6, 2026
@codspeed-hq
Copy link
Copy Markdown

codspeed-hq bot commented Mar 6, 2026

Merging this PR will not alter performance

✅ 58 untouched benchmarks
⏩ 156 skipped benchmarks1


Comparing Netail:feat/rust-1-94-0 (db6a942) with main (5046d2b)

Open in CodSpeed

Footnotes

  1. 156 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@ematipico ematipico merged commit 64ce544 into biomejs:main Mar 6, 2026
17 checks passed
ematipico pushed a commit that referenced this pull request Mar 6, 2026
@Netail Netail deleted the feat/rust-1-94-0 branch March 17, 2026 20:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-Linter Area: linter L-JavaScript Language: JavaScript and super languages

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants