Skip to content

refactor(css): align scss expression node variants#9340

Merged
denbezrukov merged 2 commits intomainfrom
db/remove-node-variants-scss
Mar 5, 2026
Merged

refactor(css): align scss expression node variants#9340
denbezrukov merged 2 commits intomainfrom
db/remove-node-variants-scss

Conversation

@denbezrukov
Copy link
Contributor

Summary

Remove unused variants

Test Plan

Green CI

Docs

@changeset-bot
Copy link

changeset-bot bot commented Mar 5, 2026

⚠️ No Changeset found

Latest commit: f1c7fbf

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added A-Parser Area: parser A-Formatter Area: formatter A-Tooling Area: internal tools L-CSS Language: CSS and super languages labels Mar 5, 2026
@github-actions
Copy link
Contributor

github-actions bot commented Mar 5, 2026

Parser conformance results on

js/262

Test result main count This PR count Difference
Total 52978 52978 0
Passed 51758 51758 0
Failed 1178 1178 0
Panics 42 42 0
Coverage 97.70% 97.70% 0.00%

jsx/babel

Test result main count This PR count Difference
Total 38 38 0
Passed 37 37 0
Failed 1 1 0
Panics 0 0 0
Coverage 97.37% 97.37% 0.00%

markdown/commonmark

Test result main count This PR count Difference
Total 652 652 0
Passed 652 652 0
Failed 0 0 0
Panics 0 0 0
Coverage 100.00% 100.00% 0.00%

symbols/microsoft

Test result main count This PR count Difference
Total 5466 5466 0
Passed 1915 1915 0
Failed 3551 3551 0
Panics 0 0 0
Coverage 35.03% 35.03% 0.00%

ts/babel

Test result main count This PR count Difference
Total 636 636 0
Passed 568 568 0
Failed 68 68 0
Panics 0 0 0
Coverage 89.31% 89.31% 0.00%

ts/microsoft

Test result main count This PR count Difference
Total 18875 18875 0
Passed 13014 13014 0
Failed 5860 5860 0
Panics 1 1 0
Coverage 68.95% 68.95% 0.00%

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Mar 5, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 0beb9913-99ba-4225-9cc4-28807382d4d0

📥 Commits

Reviewing files that changed from the base of the PR and between 87cfaf3 and f1c7fbf.

⛔ Files ignored due to path filters (1)
  • crates/biome_css_syntax/src/generated/nodes.rs is excluded by !**/generated/**, !**/generated/** and included by **
📒 Files selected for processing (1)
  • xtask/codegen/css.ungram
💤 Files with no reviewable changes (1)
  • xtask/codegen/css.ungram

Walkthrough

This change removes support for two SCSS expression variants from the formatter and grammar. The ScssKeywordArgument and ScssArbitraryArgument cases are deleted from the formatter's match statement in the expression module, whilst the corresponding union members are removed from the AnyScssExpression definition in the grammar file.

Possibly related PRs

  • PR #9227: Directly inverse operation—adds the same ScssKeywordArgument and ScssArbitraryArgument variants with their formatter support to AnyScssExpression.
  • PR #9222: Also modifies the AnyScssExpression union and its formatter match arms, adding alternative expression variants.

Suggested labels

L-SCSS

Suggested reviewers

  • ematipico
  • siketyan
🚥 Pre-merge checks | ✅ 2
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately reflects the main change: removing ScssKeywordArgument and ScssArbitraryArgument variants to align SCSS expression node variants.
Description check ✅ Passed The description is concise but related to the changeset, stating the purpose is to remove unused variants with a green CI test plan.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch db/remove-node-variants-scss

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@codspeed-hq
Copy link

codspeed-hq bot commented Mar 5, 2026

Merging this PR will not alter performance

✅ 29 untouched benchmarks
⏩ 187 skipped benchmarks1


Comparing db/remove-node-variants-scss (f1c7fbf) with main (bfa6157)

Open in CodSpeed

Footnotes

  1. 187 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@denbezrukov denbezrukov merged commit b535f60 into main Mar 5, 2026
17 checks passed
@denbezrukov denbezrukov deleted the db/remove-node-variants-scss branch March 5, 2026 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-Formatter Area: formatter A-Parser Area: parser A-Tooling Area: internal tools L-CSS Language: CSS and super languages

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants