fix: lowercase component member expressions in Astro/Svelte#9302
Merged
dyc3 merged 15 commits intobiomejs:mainfrom Mar 4, 2026
Merged
fix: lowercase component member expressions in Astro/Svelte#9302dyc3 merged 15 commits intobiomejs:mainfrom
dyc3 merged 15 commits intobiomejs:mainfrom
Conversation
🦋 Changeset detectedLatest commit: e8911b7 The changes in this PR will be included in the next version bump. This PR includes changesets to release 13 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
A-Parser
Contributor
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
WalkthroughAdds lexer and parser support to recognise and emit dot (PRD) tokens for lowercase component member expressions inside tag names for Svelte and Astro. Introduces an HtmlReLexContext variant Possibly related PRs
Suggested reviewers
🚥 Pre-merge checks | ✅ 4✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 2
🧹 Nitpick comments (1)
crates/biome_html_formatter/tests/specs/html/svelte/lowercase-member.svelte (1)
1-4: Add one guard case for dotted attributes to prevent collateral regressions.Given dot lexing changed in tag contexts, please add a non-component case like
<div data.foo="x" />to lock attribute behaviour too.Based on learnings: “Add tests for all code changes ... bug fixes need tests that reproduce the bug and validate the fix.”
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@crates/biome_html_formatter/tests/specs/html/svelte/lowercase-member.svelte` around lines 1 - 4, The spec currently tests dotted names in tag and component positions (e.g., <form.Field>, <Data.Client>, <foo.Bar.Baz />) but lacks a non-component dotted attribute case; add a guard case like <div data.foo="x" /> (matching the file's Svelte test format) to ensure attribute dot-lexing in tag contexts remains correct and prevents regressions when changing dot handling in tags.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@crates/biome_html_parser/src/lexer/mod.rs`:
- Line 138: The lexer currently emits a standalone dot token (PRD =>
self.consume_byte(T![.]) and the same logic duplicated around the other match at
the later spot), which splits dotted attribute names like data.foo into separate
tokens and breaks parse_attribute; restrict dot tokenisation to component-name
contexts only by guarding those consume_byte(T![.]) calls with the lexer
state/check used for component names (e.g., only call self.consume_byte(T![.])
when in the ComponentName/component-name parsing context or when a helper like
is_component_name_context() / self.state == TokenizerState::ComponentName is
true); otherwise let the byte fall through to the identifier/attribute parsing
path so dots remain part of attribute names and parse_attribute can handle them.
In `@crates/biome_html_parser/src/syntax/mod.rs`:
- Around line 195-203: The lookahead for member expressions currently uses
p.nth_at(1, T![.]) while lexing is in HtmlLexContext::InsideTag so '.' isn’t
recognized; update the has_member_expression check to perform the lookahead
using the same component name lexing context used for parsing (i.e., use
component_name_context(p) when peeking for T![.] rather than the default
context). Concretely, replace the p.nth_at(1, T![.]) usage with the
context-aware lookahead variant (or a small helper) that supplies
component_name_context(p) so that is_possible_component, the
has_member_expression check, and the subsequent component parsing (m,
p.bump_with_context(HTML_LITERAL, component_name_context(p))) all see '.' as a
token and member chains like <form.Field> are detected. Ensure the new
helper/variant uses the exact same component_name_context(p) symbol so lexing
behavior is consistent.
---
Nitpick comments:
In `@crates/biome_html_formatter/tests/specs/html/svelte/lowercase-member.svelte`:
- Around line 1-4: The spec currently tests dotted names in tag and component
positions (e.g., <form.Field>, <Data.Client>, <foo.Bar.Baz />) but lacks a
non-component dotted attribute case; add a guard case like <div data.foo="x" />
(matching the file's Svelte test format) to ensure attribute dot-lexing in tag
contexts remains correct and prevents regressions when changing dot handling in
tags.
ℹ️ Review info
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (2)
crates/biome_html_formatter/tests/specs/html/astro/lowercase-member.astro.snapis excluded by!**/*.snapand included by**crates/biome_html_formatter/tests/specs/html/svelte/lowercase-member.svelte.snapis excluded by!**/*.snapand included by**
📒 Files selected for processing (5)
.changeset/wet-dingos-spend.mdcrates/biome_html_formatter/tests/specs/html/astro/lowercase-member.astrocrates/biome_html_formatter/tests/specs/html/svelte/lowercase-member.sveltecrates/biome_html_parser/src/lexer/mod.rscrates/biome_html_parser/src/syntax/mod.rs
Merging this PR will degrade performance by 8.35%
Performance Changes
Comparing 
Footnotes
|
dyc3
requested changes
Mar 2, 2026
Contributor
dyc3
left a comment
dyc3
left a comment
There was a problem hiding this comment.
Parser tests are missing (only formatter tests present)
crates/biome_html_formatter/tests/specs/html/svelte/lowercase-member.svelte.snap
Show resolved
Hide resolved
Contributor
There was a problem hiding this comment.
🧹 Nitpick comments (1)
crates/biome_html_parser/src/syntax/mod.rs (1)
151-157: Keep context precedence consistent between helper and re-lex path.Line 151 prioritises Svelte over Astro, but Line 255 does the opposite. It’s safer to derive re-lex choice from the same precedence to avoid drift.
♻️ Suggested tidy-up
- if Astro.is_supported(p) { - p.re_lex(HtmlReLexContext::InsideTagAstro); - } else if Svelte.is_supported(p) { - p.re_lex(HtmlReLexContext::InsideTagSvelte); - } + match inside_tag_context(p) { + HtmlLexContext::InsideTagAstro => p.re_lex(HtmlReLexContext::InsideTagAstro), + HtmlLexContext::InsideTagSvelte => p.re_lex(HtmlReLexContext::InsideTagSvelte), + _ => {} + }Also applies to: 255-259
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@crates/biome_html_parser/src/syntax/mod.rs` around lines 151 - 157, The helper function inside_tag_context currently checks Vue, then Svelte, then Astro, but the re-lex path uses the opposite Svelte/Astro precedence; make the precedence consistent by aligning the check order between inside_tag_context and the re-lex logic (so both choose Svelte before Astro or vice versa). Update the conditional order in inside_tag_context or the re-lex branch (referencing inside_tag_context and the re-lex function/branch around the other check) so both use the same Vue → Svelte → Astro (or Vue → Astro → Svelte) ordering to prevent divergent context selection.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In `@crates/biome_html_parser/src/syntax/mod.rs`:
- Around line 151-157: The helper function inside_tag_context currently checks
Vue, then Svelte, then Astro, but the re-lex path uses the opposite Svelte/Astro
precedence; make the precedence consistent by aligning the check order between
inside_tag_context and the re-lex logic (so both choose Svelte before Astro or
vice versa). Update the conditional order in inside_tag_context or the re-lex
branch (referencing inside_tag_context and the re-lex function/branch around the
other check) so both use the same Vue → Svelte → Astro (or Vue → Astro → Svelte)
ordering to prevent divergent context selection.
ℹ️ Review info
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (4)
crates/biome_html_formatter/tests/specs/html/astro/lowercase-member.astro.snapis excluded by!**/*.snapand included by**crates/biome_html_formatter/tests/specs/html/svelte/lowercase-member.svelte.snapis excluded by!**/*.snapand included by**crates/biome_html_parser/tests/html_specs/ok/astro/lowercase_component_member.astro.snapis excluded by!**/*.snapand included by**crates/biome_html_parser/tests/html_specs/ok/svelte/lowercase_component_member.svelte.snapis excluded by!**/*.snapand included by**
📒 Files selected for processing (9)
.changeset/wet-dingos-spend.mdcrates/biome_cli/tests/cases/regression_tests.rscrates/biome_html_formatter/tests/specs/html/astro/lowercase-member.astrocrates/biome_html_formatter/tests/specs/html/svelte/lowercase-member.sveltecrates/biome_html_parser/src/lexer/mod.rscrates/biome_html_parser/src/syntax/mod.rscrates/biome_html_parser/src/token_source.rscrates/biome_html_parser/tests/html_specs/ok/astro/lowercase_component_member.astrocrates/biome_html_parser/tests/html_specs/ok/svelte/lowercase_component_member.svelte
✅ Files skipped from review due to trivial changes (1)
- crates/biome_html_parser/tests/html_specs/ok/svelte/lowercase_component_member.svelte
🚧 Files skipped from review as they are similar to previous changes (1)
- crates/biome_html_formatter/tests/specs/html/svelte/lowercase-member.svelte
Contributor
There was a problem hiding this comment.
🧹 Nitpick comments (1)
crates/biome_html_parser/src/syntax/mod.rs (1)
151-160: Keep lex-context precedence consistent in one place.
inside_tag_context()prefers Svelte before Astro, but the post-tag re-lex inparse_element()does Astro before Svelte. If both flags are ever enabled together, that can cause mid-tag tokenisation drift. Worth consolidating this precedence to a single source of truth.♻️ Small consistency refactor
- if Astro.is_supported(p) { - p.re_lex(HtmlReLexContext::InsideTagAstro); - } else if Svelte.is_supported(p) { - p.re_lex(HtmlReLexContext::InsideTagSvelte); - } + if Svelte.is_supported(p) { + p.re_lex(HtmlReLexContext::InsideTagSvelte); + } else if Astro.is_supported(p) { + p.re_lex(HtmlReLexContext::InsideTagAstro); + }Also applies to: 255-258
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@crates/biome_html_parser/src/syntax/mod.rs` around lines 151 - 160, The lex-context precedence is inconsistent: inside_tag_context() checks Vue -> Svelte -> Astro, while parse_element() re-lex post-tag using Astro before Svelte, which can cause tokenisation drift when multiple flags are enabled; unify the precedence by making parse_element() use inside_tag_context() (or vice versa) so both use the same order (e.g., Vue, Svelte, Astro) and update the other occurrence noted around lines 255-258 to call the same helper (inside_tag_context) or the same precedence source so there is a single source of truth for lex-context selection.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In `@crates/biome_html_parser/src/syntax/mod.rs`:
- Around line 151-160: The lex-context precedence is inconsistent:
inside_tag_context() checks Vue -> Svelte -> Astro, while parse_element() re-lex
post-tag using Astro before Svelte, which can cause tokenisation drift when
multiple flags are enabled; unify the precedence by making parse_element() use
inside_tag_context() (or vice versa) so both use the same order (e.g., Vue,
Svelte, Astro) and update the other occurrence noted around lines 255-258 to
call the same helper (inside_tag_context) or the same precedence source so there
is a single source of truth for lex-context selection.
dyc3
reviewed
Mar 3, 2026
dyc3
reviewed
Mar 4, 2026
dyc3
approved these changes
Mar 4, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #9300 "Formatter breaks dots notation in Svelte component names"
Fixed Svelte/Astro lowercase component member expressions being formatted with extra space.
Input
Output
Test Plan
Test Plan