Skip to content

fix(js_analyze): mention which dependency the useExhaustiveDependencies fix adds to the list#9243

Merged
ematipico merged 2 commits intobiomejs:mainfrom
Netail:fix/7813
Feb 25, 2026
Merged

fix(js_analyze): mention which dependency the useExhaustiveDependencies fix adds to the list#9243
ematipico merged 2 commits intobiomejs:mainfrom
Netail:fix/7813

Conversation

@Netail
Copy link
Member

@Netail Netail commented Feb 25, 2026

Summary

mention in the useExhaustiveDependencies quick fix which dependency it will add to the dependency list.

Closes #7813

Test Plan

unit tests

Docs

@github-actions github-actions bot added A-Linter Area: linter L-JavaScript Language: JavaScript and super languages labels Feb 25, 2026
@Netail Netail requested a review from mdevils February 25, 2026 13:52
@Netail Netail changed the title fix(js_analyze): mention which dependency it will add fix(js_analyze): mention which dependency the useExhaustiveDependencies fix will add to the list Feb 25, 2026
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Feb 25, 2026

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 5d6feee and 5553994.

📒 Files selected for processing (1)
  • .changeset/deep-women-retire.md

Walkthrough

Updates the useExhaustiveDependencies quick-fix logic to extract the dependency name and its capture range from nested captures, build the new array element from that range, and include the actual dependency name in the diagnostic message. Adds a patch-level changeset entry updating version metadata. No public API signatures changed.

Possibly related PRs

  • PR #9243: Adjusts use_exhaustive_dependencies.rs to include the actual dependency name and its capture range in quick-fix diagnostics.
  • PR #7498: Modifies use_exhaustive_dependencies.rs to improve construction of missing dependency expressions (handles shorthand object members and JsReferenceIdentifier cases).

Suggested labels

A-Diagnostic

Suggested reviewers

  • mdevils
🚥 Pre-merge checks | ✅ 4
✅ Passed checks (4 passed)
Check name Status Explanation
Description check ✅ Passed The description clearly explains the fix targets the useExhaustiveDependencies rule quick fix, making suggestions descriptive about what will be added.
Linked Issues check ✅ Passed The PR implements a partial solution to #7813 by making quick fix labels descriptive with the dependency name, fulfilling the primary improvement requested.
Out of Scope Changes check ✅ Passed All changes are directly related to improving the useExhaustiveDependencies quick fix messaging as per issue #7813.
Title check ✅ Passed The title directly reflects the main change: clarifying which dependency the useExhaustiveDependencies fix adds by including the dependency name in the diagnostic message.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Tip

Try Coding Plans. Let us write the prompt for your AI agent so you can ship faster (with fewer bugs).
Share your feedback on Discord.


Comment @coderabbitai help to get the list of available commands and usage tips.

@Netail Netail changed the title fix(js_analyze): mention which dependency the useExhaustiveDependencies fix will add to the list fix(js_analyze): mention which dependency the useExhaustiveDependencies fix adds to the list Feb 25, 2026
@codspeed-hq
Copy link

codspeed-hq bot commented Feb 25, 2026

Merging this PR will not alter performance

✅ 58 untouched benchmarks
⏩ 156 skipped benchmarks1


Comparing Netail:fix/7813 (5553994) with main (75f1e12)

Open in CodSpeed

Footnotes

  1. 156 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

Copy link
Member

@ematipico ematipico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great improvement!

@changeset-bot
Copy link

changeset-bot bot commented Feb 25, 2026

🦋 Changeset detected

Latest commit: 5553994

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 13 packages
Name Type
@biomejs/biome Patch
@biomejs/cli-win32-x64 Patch
@biomejs/cli-win32-arm64 Patch
@biomejs/cli-darwin-x64 Patch
@biomejs/cli-darwin-arm64 Patch
@biomejs/cli-linux-x64 Patch
@biomejs/cli-linux-arm64 Patch
@biomejs/cli-linux-x64-musl Patch
@biomejs/cli-linux-arm64-musl Patch
@biomejs/wasm-web Patch
@biomejs/wasm-bundler Patch
@biomejs/wasm-nodejs Patch
@biomejs/backend-jsonrpc Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@ematipico ematipico merged commit 1992a85 into biomejs:main Feb 25, 2026
15 of 17 checks passed
@github-actions github-actions bot mentioned this pull request Feb 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-Linter Area: linter L-JavaScript Language: JavaScript and super languages

Projects

None yet

Development

Successfully merging this pull request may close these issues.

💅 Quick Fix for useExhaustiveDependencies has long list of suggestions

2 participants