Conversation
|
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review infoConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro 📒 Files selected for processing (2)
🚧 Files skipped from review as they are similar to previous changes (2)
WalkthroughThe PR unifies JSON reporter behaviour by always serialising Possibly related PRs
Suggested labels
Suggested reviewers
🚥 Pre-merge checks | ✅ 2✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches
🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@crates/biome_cli/src/reporter/mod.rs`:
- Around line 58-60: The code serializes self.duration as nanoseconds (creating
duration_value via
AnyJsonValue::JsonNumberValue(json_number_value(json_number_literal(self.duration.as_nanos()))))
while scannerDuration is serialized using as_millis(), mixing units; update the
serialization for duration_value to use the same unit as scannerDuration (e.g.,
use self.duration.as_millis() or convert scannerDuration to nanos) so both use
consistent units, and ensure the json_number_literal call and AnyJsonValue
construction (the duration_value creation) reflect that chosen unit and naming
so the payload contract is consistent.
ea6caeb to
2221da7
Compare
Summary
Small bug fix for the CI. This won't affect production so it doesn't need a changeset
Test Plan
CI must stay the same
Docs