Open
Conversation
🦋 Changeset detectedLatest commit: 97d1e15 The changes in this PR will be included in the next version bump. This PR includes changesets to release 13 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
A-CLI
Merging this PR will not alter performance
Comparing 
Footnotes
|
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review infoConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro ⛔ Files ignored due to path filters (8)
📒 Files selected for processing (7)
🚧 Files skipped from review as they are similar to previous changes (4)
WalkthroughAdds a new HTML lint rule Possibly related PRs
Suggested reviewers
🚥 Pre-merge checks | ✅ 2✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches
🧪 Generate unit tests (beta)
Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 4
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In @.changeset/add-use-vue-scoped-styles.md:
- Around line 1-5: Update the changeset to reflect this is a new lint rule:
change the release type from "patch" to "minor" and add a note in the body that
the new rule useVueScopedStyles defaults to Severity::Information (i.e.,
RuleMetadata::default()) when no explicit severity is set in declare_lint_rule!,
so callers should be aware of the default severity level; keep the concise
description about enforcing scoped/module on <style> blocks and mention the
default severity explicitly.
In `@crates/biome_html_analyze/src/lint/nursery/use_vue_scoped_styles.rs`:
- Around line 115-119: Update the user-facing autofix message passed into
RuleAction::new (the markup! invocation created via ctx.metadata() in
use_vue_scoped_styles) to fix the grammar: change "Add the \"scoped\" attribute
so the styles in will only apply to this component." to a clean sentence such as
"Add the \"scoped\" attribute so the styles will only apply to this component."
Ensure the corrected string is used in the same markup! call that constructs the
RuleAction description.
- Around line 103-110: The token currently embeds a leading space by calling
HtmlSyntaxToken::new_detached(HtmlSyntaxKind::HTML_LITERAL, " scoped", ...,
...); instead remove the embedded whitespace (use "scoped" or empty literal as
appropriate) and attach the space as leading trivia using
TriviaPiece::whitespace() so spacing is handled consistently (see the pattern in
use_vue_vapor.rs); update the HtmlSyntaxToken creation for the token used by
make::html_attribute_name and keep the surrounding flow that wraps it in
AnyHtmlAttribute::HtmlAttribute and the attribute list unchanged.
In `@crates/biome_rule_options/src/use_vue_scoped_styles.rs`:
- Around line 1-6: Add an inline rustdoc comment above the
UseVueScopedStylesOptions struct: insert a one-line /// comment that briefly
describes the purpose of this options struct (e.g., "Options for the
use_vue_scoped_styles lint/assist" or similar) so it appears in generated docs;
place it immediately above the pub struct UseVueScopedStylesOptions {}
declaration and update the wording if fields are added later.
Comment on lines
1
to
5
| --- | ||
| "@biomejs/biome": patch | ||
| --- | ||
|
|
||
| Added the `useVueScopedStyles` lint rule for Vue SFCs. This rule enforces that `<style>` blocks have the `scoped` attribute (or `module` for CSS Modules), preventing style leakage and conflicts between components. |
Contributor
There was a problem hiding this comment.
Changeset should be minor and mention the default severity.
This is a new lint rule, so the change type should be minor. Also please note that the rule defaults to Severity::Information because no explicit severity is set.
♻️ Proposed update
---
-"@biomejs/biome": patch
+"@biomejs/biome": minor
---
Added the `useVueScopedStyles` lint rule for Vue SFCs. This rule enforces that `<style>` blocks have the `scoped` attribute (or `module` for CSS Modules), preventing style leakage and conflicts between components.
+Note: This rule defaults to `Severity::Information` unless configured.As per coding guidelines: Use change types in changesets: patch for bug fixes and non-breaking changes (targets main branch), minor for new features and non-breaking additions (targets next branch), major for breaking changes (targets next branch).
Based on learnings: In changeset markdown files (e.g., .changeset/*), document that when a lint rule does not explicitly set the severity in declare_lint_rule!, the default severity is Severity::Information (RuleMetadata::default()), not Severity::Error.
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In @.changeset/add-use-vue-scoped-styles.md around lines 1 - 5, Update the
changeset to reflect this is a new lint rule: change the release type from
"patch" to "minor" and add a note in the body that the new rule
useVueScopedStyles defaults to Severity::Information (i.e.,
RuleMetadata::default()) when no explicit severity is set in declare_lint_rule!,
so callers should be aware of the default severity level; keep the concise
description about enforcing scoped/module on <style> blocks and mention the
default severity explicitly.
Comment on lines
103
to
110
| let token = HtmlSyntaxToken::new_detached(HtmlSyntaxKind::HTML_LITERAL, " scoped", [], []); | ||
|
|
||
| let attr = AnyHtmlAttribute::HtmlAttribute( | ||
| make::html_attribute(make::html_attribute_name(token)).build(), | ||
| ); | ||
| let mut items: Vec<AnyHtmlAttribute> = old_attributes.iter().collect(); | ||
| items.push(attr); | ||
| let new_attributes = make::html_attribute_list(items); |
Contributor
There was a problem hiding this comment.
🧩 Analysis chain
🏁 Script executed:
# First, let's look at the actual file and its context
cat -n crates/biome_html_analyze/src/lint/nursery/use_vue_scoped_styles.rs | head -130 | tail -40Repository: biomejs/biome
Length of output: 2151
🏁 Script executed:
# Check for similar detached token constructions with HTML_LITERAL
rg -n "new_detached.*HTML_LITERAL" -A 2 -B 2Repository: biomejs/biome
Length of output: 621
🏁 Script executed:
# Search for how html_attribute_name is typically used
rg -n "html_attribute_name" -A 2 -B 2Repository: biomejs/biome
Length of output: 2625
🏁 Script executed:
# Check the html_factory module for available helper functions
fd html_factory crates/ --type fRepository: biomejs/biome
Length of output: 39
🏁 Script executed:
# Look at how other attributes are created in the same file
cat -n crates/biome_html_analyze/src/lint/nursery/use_vue_scoped_styles.rs | grep -A 10 "make::html_attribute"Repository: biomejs/biome
Length of output: 881
🏁 Script executed:
# Look at how vapor_token is created in the related file
cat -n crates/biome_html_analyze/src/lint/nursery/use_vue_vapor.rs | grep -B 10 "vapor_token"Repository: biomejs/biome
Length of output: 935
🏁 Script executed:
# Check if html_factory has helper functions for token creation
rg -n "pub fn" crates/biome_html_factory/src/generated/node_factory.rs | head -20Repository: biomejs/biome
Length of output: 1190
🏁 Script executed:
# Search for TriviaPiece usage patterns in html files
rg -n "TriviaPiece" crates/biome_html_analyze/ -A 2 -B 2Repository: biomejs/biome
Length of output: 4714
🏁 Script executed:
# Check the imports and what's available in the file
head -30 crates/biome_html_analyze/src/lint/nursery/use_vue_scoped_styles.rsRepository: biomejs/biome
Length of output: 1036
Use trivia for spacing instead of embedding whitespace in the token text.
The current code embeds a space in " scoped", which can cause issues when trivia is already present. The established pattern in the codebase (see use_vue_vapor.rs for reference) handles spacing via TriviaPiece::whitespace() instead.
Suggested adjustment
-use biome_rowan::{AstNode, AstNodeList, BatchMutationExt};
+use biome_rowan::{AstNode, AstNodeList, BatchMutationExt, TriviaPiece};
- let token = HtmlSyntaxToken::new_detached(HtmlSyntaxKind::HTML_LITERAL, " scoped", [], []);
+ let token = HtmlSyntaxToken::new_detached(
+ HtmlSyntaxKind::HTML_LITERAL,
+ "scoped",
+ [TriviaPiece::whitespace(1)],
+ [],
+ );🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@crates/biome_html_analyze/src/lint/nursery/use_vue_scoped_styles.rs` around
lines 103 - 110, The token currently embeds a leading space by calling
HtmlSyntaxToken::new_detached(HtmlSyntaxKind::HTML_LITERAL, " scoped", ...,
...); instead remove the embedded whitespace (use "scoped" or empty literal as
appropriate) and attach the space as leading trivia using
TriviaPiece::whitespace() so spacing is handled consistently (see the pattern in
use_vue_vapor.rs); update the HtmlSyntaxToken creation for the token used by
make::html_attribute_name and keep the surrounding flow that wraps it in
AnyHtmlAttribute::HtmlAttribute and the attribute list unchanged.
Comment on lines
115
to
119
| Some(biome_analyze::RuleAction::new( | ||
| ctx.metadata().action_category(ctx.category(), ctx.group()), | ||
| ctx.metadata().applicability(), | ||
| markup! { "Add the "<Emphasis>"scoped"</Emphasis>" attribute so the styles in will only apply to this component." }.to_owned(), | ||
| mutation, |
Contributor
There was a problem hiding this comment.
Tidy the autofix message grammar.
There’s a tiny typo gremlin in the user-facing text.
✍️ Suggested tweak
- markup! { "Add the "<Emphasis>"scoped"</Emphasis>" attribute so the styles in will only apply to this component." }.to_owned(),
+ markup! { "Add the "<Emphasis>"scoped"</Emphasis>" attribute so the styles in this block only apply to this component." }.to_owned(),🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@crates/biome_html_analyze/src/lint/nursery/use_vue_scoped_styles.rs` around
lines 115 - 119, Update the user-facing autofix message passed into
RuleAction::new (the markup! invocation created via ctx.metadata() in
use_vue_scoped_styles) to fix the grammar: change "Add the \"scoped\" attribute
so the styles in will only apply to this component." to a clean sentence such as
"Add the \"scoped\" attribute so the styles will only apply to this component."
Ensure the corrected string is used in the same markup! call that constructs the
RuleAction description.
Comment on lines
1
to
6
| use biome_deserialize_macros::{Deserializable, Merge}; | ||
| use serde::{Deserialize, Serialize}; | ||
| #[derive(Default, Clone, Debug, Deserialize, Deserializable, Merge, Eq, PartialEq, Serialize)] | ||
| #[cfg_attr(feature = "schema", derive(schemars::JsonSchema))] | ||
| #[serde(rename_all = "camelCase", deny_unknown_fields, default)] | ||
| pub struct UseVueScopedStylesOptions {} |
Contributor
There was a problem hiding this comment.
Add a rustdoc comment for the options struct.
Even a one-liner helps when this shows up in generated docs.
✍️ Suggested tweak
+/// Options for the `useVueScopedStyles` rule.
+/// Currently empty; reserved for future configuration.
#[derive(Default, Clone, Debug, Deserialize, Deserializable, Merge, Eq, PartialEq, Serialize)]
#[cfg_attr(feature = "schema", derive(schemars::JsonSchema))]
#[serde(rename_all = "camelCase", deny_unknown_fields, default)]
pub struct UseVueScopedStylesOptions {}As per coding guidelines: Use inline rustdoc documentation for rules, assists, and their options.
📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
Suggested change
| use biome_deserialize_macros::{Deserializable, Merge}; | |
| use serde::{Deserialize, Serialize}; | |
| #[derive(Default, Clone, Debug, Deserialize, Deserializable, Merge, Eq, PartialEq, Serialize)] | |
| #[cfg_attr(feature = "schema", derive(schemars::JsonSchema))] | |
| #[serde(rename_all = "camelCase", deny_unknown_fields, default)] | |
| pub struct UseVueScopedStylesOptions {} | |
| use biome_deserialize_macros::{Deserializable, Merge}; | |
| use serde::{Deserialize, Serialize}; | |
| /// Options for the `useVueScopedStyles` rule. | |
| /// Currently empty; reserved for future configuration. | |
| #[derive(Default, Clone, Debug, Deserialize, Deserializable, Merge, Eq, PartialEq, Serialize)] | |
| #[cfg_attr(feature = "schema", derive(schemars::JsonSchema))] | |
| #[serde(rename_all = "camelCase", deny_unknown_fields, default)] | |
| pub struct UseVueScopedStylesOptions {} |
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@crates/biome_rule_options/src/use_vue_scoped_styles.rs` around lines 1 - 6,
Add an inline rustdoc comment above the UseVueScopedStylesOptions struct: insert
a one-line /// comment that briefly describes the purpose of this options struct
(e.g., "Options for the use_vue_scoped_styles lint/assist" or similar) so it
appears in generated docs; place it immediately above the pub struct
UseVueScopedStylesOptions {} declaration and update the wording if fields are
added later.
dyc3
force-pushed
the
dyc3/use-vue-scoped-styles
branch
from
68d5e2b to
f61ced2
Compare
Contributor
There was a problem hiding this comment.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Duplicate comments:
In `@crates/biome_html_analyze/src/lint/nursery/use_vue_scoped_styles.rs`:
- Line 124: Fix the grammar in the action message inside the markup! call in
use_vue_scoped_styles.rs: locate the string that currently reads "Add the
"scoped" attribute so the styles in will only apply to this component." (the
markup! { ... } containing Emphasis) and change it to a grammatically correct
phrase such as "Add the \"scoped\" attribute so the styles will only apply to
this component." or "Add the \"scoped\" attribute so the styles in this block
will only apply to this component."
- Line 109: The token creation embeds a leading space in the token text instead
of using trivia; change the HtmlSyntaxToken::new_detached call that creates the
variable `token` (currently using HtmlSyntaxKind::HTML_LITERAL and text "
scoped") to use the text "scoped" and pass a leading trivia piece of
TriviaPiece::whitespace(1) (following the pattern used in use_vue_vapor.rs) so
spacing is represented as trivia rather than in the token content.
In `@crates/biome_rule_options/src/use_vue_scoped_styles.rs`:
- Around line 1-6: Add a brief Rust doc comment for the
UseVueScopedStylesOptions struct so it shows up in generated docs: locate the
pub struct UseVueScopedStylesOptions declaration and add a short /// doc comment
describing what the options control (one sentence) and any important
fields/behavior; keep it concise and above the #[derive(...)] attributes so
rustdoc picks it up when docs are generated.
Member
|
@dyc3, can we make the rule more general and not tailored to Vue? (We can still assign the Vue domain). That's because also Astro allows you to do so: https://docs.astro.build/en/guides/styling/#global-styles |
Contributor
Author
|
Ah, I didn't know that astro had that. I had it vue specific because svelte's component styles are scoped automatically. Sure, we can do that. |
Member
|
I mean, even Svelte has global styles.... https://svelte.dev/docs/svelte/global-styles 😅 😆 |
Contributor
Author
|
Yeah true. I'll stick to just the HTML side of this rule for now, and leave the CSS part to another PR. |
dyc3
force-pushed
the
dyc3/use-vue-scoped-styles
branch
from
f61ced2 to
3af7edc
Compare
Contributor
There was a problem hiding this comment.
Actionable comments posted: 5
🧹 Nitpick comments (2)
crates/biome_html_analyze/src/lint/nursery/use_scoped_styles.rs (1)
69-72: KeepGlobalStylesKindprivate and place it belowimpl Rule.This enum is internal rule state; it does not need
pub, and local convention is to place helper types below the rule impl.♻️ Suggested patch (visibility)
-pub enum GlobalStylesKind { +enum GlobalStylesKind { Vue, Astro { directive: AstroIsDirective }, }Based on learnings: In crates/biome_analyze/**/*.rs rule files, all helper functions, structs, and enums must be placed below the
impl Ruleblock. The only exception is when declaring a node union to use in the rule's Query type, which can be kept above the rule block for better readability.🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@crates/biome_html_analyze/src/lint/nursery/use_scoped_styles.rs` around lines 69 - 72, Make the enum GlobalStylesKind non-public and move its declaration below the impl Rule block: change its visibility from pub to private (remove pub) and cut/paste the enum definition so it appears after the impl Rule implementation in use_scoped_styles.rs, keeping the variant names (Vue, Astro and Astro { directive: AstroIsDirective }) intact so references inside the rule still compile.crates/biome_html_analyze/tests/specs/nursery/useScopedStyles/invalid.astro (1)
1-7: Please add avalid.astrocompanion fixture.You’ve got the failing Astro case; adding a passing
<style>...</style>case would pin the default-scoped behaviour too.Based on learnings: Applies to crates/biome_analyze/tests/specs/**/* : Create snapshot tests for rules inside
tests/specs/folder organized by group and rule name. Use files prefixed withinvalidfor code that triggers the rule andvalidfor code that doesn't.🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@crates/biome_html_analyze/tests/specs/nursery/useScopedStyles/invalid.astro` around lines 1 - 7, Add a companion passing fixture named valid.astro next to the failing invalid.astro to assert default-scoped behavior: create a file alongside invalid.astro containing a normal <style> block (e.g., <style> .foo { color: red; } </style>) that should NOT produce diagnostics; this follows the tests/specs/* organization and naming convention for the useScopedStyles rule so snapshot tests compare invalid (triggers) vs valid (no diagnostics).
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In @.changeset/add-use-vue-scoped-styles.md:
- Line 5: Update the changeset text to match the implemented rule name and
behavior: replace references to `useVueScopedStyles` and "Vue-only" with
`useScopedStyles` and mention that it also enforces Astro `is:global` handling
(or that it accepts `module` for CSS Modules where applicable); ensure the
description explains that the rule applies to Vue SFCs and Astro files and
enforces scoped/module or Astro `is:global` usage to prevent style leakage.
In `@crates/biome_html_analyze/src/lint/nursery/use_scoped_styles.rs`:
- Line 177: The message in the markup! string contains a typo ("styles in will
only apply…"); update the text used in the markup! call (the string passed to
markup! and then .to_owned()) so it reads correctly, e.g. "Add the \"scoped\"
attribute so the styles will only apply to this component." — locate the markup!
{ "Add the "<Emphasis>"scoped"</Emphasis>" attribute ..." } expression and
replace the malformed sentence accordingly.
- Around line 15-20: Update the rustdoc lead for the rule in
use_scoped_styles.rs so it reflects current behavior: instead of saying it
applies to Vue-only, state that the rule enforces scoped styles for Vue SFCs and
also diagnoses Astro `is:global` usage; edit the top comment block (the
docstring above the rule implementation, e.g., for the UseScopedStyles lint) to
mention both Vue and Astro `is:global` handling and briefly describe the
difference in how each framework treats scoped/global styles.
- Around line 109-113: The loop over is_directives currently uses the try
operator (?), which can early-return from the whole function on a malformed
directive and skip remaining directives; change the per-directive extraction to
handle failures locally (e.g., use directive.value().and_then(|v|
v.name().ok()).and_then(|n| n.token_text_trimmed()).map(|name_text| (name_text,
directive.clone())) or use an if-let chain) so that if any step yields None you
continue to the next directive instead of returning; if
name_text.eq_ignore_ascii_case("global") then return
Some(GlobalStylesKind::Astro { directive }) as before.
In `@crates/biome_rule_options/src/use_scoped_styles.rs`:
- Around line 3-6: Add an inline rustdoc comment for the UseScopedStylesOptions
struct describing its purpose and that it currently has no configurable fields
(so it acts as a marker/default options type); update the doc to be a short
one-line summary above the declaration of UseScopedStylesOptions and mention
that additional options can be added later, referencing the struct name to
locate where to add the comment.
---
Nitpick comments:
In `@crates/biome_html_analyze/src/lint/nursery/use_scoped_styles.rs`:
- Around line 69-72: Make the enum GlobalStylesKind non-public and move its
declaration below the impl Rule block: change its visibility from pub to private
(remove pub) and cut/paste the enum definition so it appears after the impl Rule
implementation in use_scoped_styles.rs, keeping the variant names (Vue, Astro
and Astro { directive: AstroIsDirective }) intact so references inside the rule
still compile.
In `@crates/biome_html_analyze/tests/specs/nursery/useScopedStyles/invalid.astro`:
- Around line 1-7: Add a companion passing fixture named valid.astro next to the
failing invalid.astro to assert default-scoped behavior: create a file alongside
invalid.astro containing a normal <style> block (e.g., <style> .foo { color:
red; } </style>) that should NOT produce diagnostics; this follows the
tests/specs/* organization and naming convention for the useScopedStyles rule so
snapshot tests compare invalid (triggers) vs valid (no diagnostics).
ℹ️ Review info
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (8)
crates/biome_cli/src/execute/migrate/eslint_any_rule_to_biome.rsis excluded by!**/migrate/eslint_any_rule_to_biome.rsand included by**crates/biome_configuration/src/analyzer/linter/rules.rsis excluded by!**/rules.rsand included by**crates/biome_diagnostics_categories/src/categories.rsis excluded by!**/categories.rsand included by**crates/biome_html_analyze/tests/specs/nursery/useScopedStyles/invalid.astro.snapis excluded by!**/*.snapand included by**crates/biome_html_analyze/tests/specs/nursery/useScopedStyles/invalid.vue.snapis excluded by!**/*.snapand included by**crates/biome_html_analyze/tests/specs/nursery/useScopedStyles/valid.vue.snapis excluded by!**/*.snapand included by**packages/@biomejs/backend-jsonrpc/src/workspace.tsis excluded by!**/backend-jsonrpc/src/workspace.tsand included by**packages/@biomejs/biome/configuration_schema.jsonis excluded by!**/configuration_schema.jsonand included by**
📒 Files selected for processing (7)
.changeset/add-use-vue-scoped-styles.mdcrates/biome_html_analyze/src/lint/nursery/use_scoped_styles.rscrates/biome_html_analyze/tests/specs/nursery/useScopedStyles/invalid.astrocrates/biome_html_analyze/tests/specs/nursery/useScopedStyles/invalid.vuecrates/biome_html_analyze/tests/specs/nursery/useScopedStyles/valid.vuecrates/biome_rule_options/src/lib.rscrates/biome_rule_options/src/use_scoped_styles.rs
🚧 Files skipped from review as they are similar to previous changes (1)
- crates/biome_rule_options/src/lib.rs
| "@biomejs/biome": patch | ||
| --- | ||
|
|
||
| Added the nursery rule `useVueScopedStyles` for Vue SFCs. This rule enforces that `<style>` blocks have the `scoped` attribute (or `module` for CSS Modules), preventing style leakage and conflicts between components. |
Contributor
There was a problem hiding this comment.
Changeset description is out of date with the implementation.
It still says useVueScopedStyles and Vue-only scope, while the shipped rule is useScopedStyles and also handles Astro is:global.
♻️ Suggested patch
-Added the nursery rule `useVueScopedStyles` for Vue SFCs. This rule enforces that `<style>` blocks have the `scoped` attribute (or `module` for CSS Modules), preventing style leakage and conflicts between components.
+Added the nursery rule `useScopedStyles` for Vue and Astro components. It enforces component-scoped styles by requiring `<style scoped>` (or `module`) in Vue SFCs and disallowing `<style is:global>` in Astro, helping prevent style leakage across components.🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In @.changeset/add-use-vue-scoped-styles.md at line 5, Update the changeset text
to match the implemented rule name and behavior: replace references to
`useVueScopedStyles` and "Vue-only" with `useScopedStyles` and mention that it
also enforces Astro `is:global` handling (or that it accepts `module` for CSS
Modules where applicable); ensure the description explains that the rule applies
to Vue SFCs and Astro files and enforces scoped/module or Astro `is:global`
usage to prevent style leakage.
crates/biome_html_analyze/src/lint/nursery/use_scoped_styles.rs
Outdated
Show resolved
Hide resolved
Comment on lines
+109
to
+113
| for directive in is_directives { | ||
| let name = directive.value().ok()?.name().ok()?; | ||
| let name_text = name.token_text_trimmed()?; | ||
| if name_text.eq_ignore_ascii_case("global") { | ||
| return Some(GlobalStylesKind::Astro { directive }); |
Contributor
There was a problem hiding this comment.
Avoid bailing out the Astro scan on one malformed directive.
Using ? here can return early and skip checking later directives on the same <style> tag.
♻️ Suggested patch
for directive in is_directives {
- let name = directive.value().ok()?.name().ok()?;
- let name_text = name.token_text_trimmed()?;
- if name_text.eq_ignore_ascii_case("global") {
+ let is_global = directive
+ .value()
+ .ok()
+ .and_then(|value| value.name().ok())
+ .and_then(|name| name.token_text_trimmed())
+ .is_some_and(|name| name.eq_ignore_ascii_case("global"));
+ if is_global {
return Some(GlobalStylesKind::Astro { directive });
}
}Based on learnings: Applies to crates/biome_analyze/**/*.rs : Use functional methods like map, filter, and and_then on Result and Option types instead of nested if let statements to avoid excessive indentation.
📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
Suggested change
| for directive in is_directives { | |
| let name = directive.value().ok()?.name().ok()?; | |
| let name_text = name.token_text_trimmed()?; | |
| if name_text.eq_ignore_ascii_case("global") { | |
| return Some(GlobalStylesKind::Astro { directive }); | |
| for directive in is_directives { | |
| let is_global = directive | |
| .value() | |
| .ok() | |
| .and_then(|value| value.name().ok()) | |
| .and_then(|name| name.token_text_trimmed()) | |
| .is_some_and(|name| name.eq_ignore_ascii_case("global")); | |
| if is_global { | |
| return Some(GlobalStylesKind::Astro { directive }); | |
| } | |
| } |
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@crates/biome_html_analyze/src/lint/nursery/use_scoped_styles.rs` around lines
109 - 113, The loop over is_directives currently uses the try operator (?),
which can early-return from the whole function on a malformed directive and skip
remaining directives; change the per-directive extraction to handle failures
locally (e.g., use directive.value().and_then(|v| v.name().ok()).and_then(|n|
n.token_text_trimmed()).map(|name_text| (name_text, directive.clone())) or use
an if-let chain) so that if any step yields None you continue to the next
directive instead of returning; if name_text.eq_ignore_ascii_case("global") then
return Some(GlobalStylesKind::Astro { directive }) as before.
crates/biome_html_analyze/src/lint/nursery/use_scoped_styles.rs
Outdated
Show resolved
Hide resolved
dyc3
force-pushed
the
dyc3/use-vue-scoped-styles
branch
from
3af7edc to
a43adc2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This adds a new html rule that enforces that
scopedbe on all<style>blocks.Mostly generated with glm-5
Test Plan
snapshots
Docs