fix(parse/html/vue): don't treat : as special token outside of vue directives#9162
fix(parse/html/vue): don't treat : as special token outside of vue directives#9162
: as special token outside of vue directives#9162Conversation
🦋 Changeset detectedLatest commit: cc5a919 The changes in this PR will be included in the next version bump. This PR includes changesets to release 13 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This stack of pull requests is managed by Graphite. Learn more about stacking. |
|
No actionable comments were generated in the recent review. 🎉 WalkthroughThis PR fixes Vue colon attribute parsing in the HTML parser by preventing colons from being consumed as part of identifiers when Vue directive prefixes (v-) are detected. The lexer now treats colon-prefixed attributes like Possibly related PRs
Suggested labels
Suggested reviewers
🚥 Pre-merge checks | ✅ 2✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches
🧪 Generate unit tests (beta)
Tip Issue Planner is now in beta. Read the docs and try it out! Share your feedback on Discord. Comment |
|
Any idea why codspeed still thinks the benchmarks are new? @ematipico |

Summary
This makes sure we only consider colons to be special if we know we are lexing a vue directive, in vue files.
partial fix for #9161
Test Plan
added snapshots, removed some invalid svelte syntax from a vue test
Docs