Conversation
🦋 Changeset detectedLatest commit: 9ff934a The changes in this PR will be included in the next version bump. This PR includes changesets to release 13 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
WalkthroughThis PR updates the Astro frontmatter lexer to reliably detect the closing Possibly related PRs
Suggested reviewers
🚥 Pre-merge checks | ✅ 4✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@crates/biome_html_parser/src/lexer/mod.rs`:
- Around line 1505-1508: The is_empty() method currently only checks
current_quote and therefore treats being inside a comment as "empty"; update
is_empty() to also consider comment state so that being inside a comment counts
as non-empty. Specifically, modify fn is_empty(&self) -> bool in the lexer to
return true only when self.current_quote.is_none() AND whatever field tracks
comments (e.g. self.comment / self.current_comment / self.in_comment) indicates
not in a comment, so that frontmatter fences like '---' inside comments won't be
treated as closing.
Merging this PR will not alter performance
Comparing Footnotes
|
|
Going to merge this, let me know if there are any concerns and i will address them |
Summary
Closes #8882
Closes #9108
Closes #9125
The code was generated via Claude Code. It suggested a different approach to the solution.
Test Plan
Added more tests.
Docs