fix(service): don't duplicate snippet's trivia when updating snippets#9051
Merged
fix(service): don't duplicate snippet's trivia when updating snippets#9051
Conversation
|
dyc3
force-pushed
the
dyc3/fix-duplicated-trivia-embedded-snippets
branch
from
fe6f5da to
9661ff4
Compare
Contributor
WalkthroughThis pull request fixes an issue where extra newlines were being added to embedded Vue Suggested labels
Suggested reviewers
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
🧪 Generate unit tests (beta)
⚔️ Resolve merge conflicts (beta)
No actionable comments were generated in the recent review. 🎉 Comment |
ematipico
approved these changes
Feb 13, 2026
Member
ematipico
left a comment
ematipico
left a comment
There was a problem hiding this comment.
Awesome! Good catch, that part isn't easy to handle
ematipico
pushed a commit
that referenced
this pull request
Feb 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
update_snippetswas duplicating snippets trivia. The root cause wasread_leading_triviagrabs the trivia from the original snippet. It then concatenated the leading trivia on the snippet's new code, which also contained leading whitespace. The result was duplicated whitespace. The same thing was happening to the trailing trivia as well.No changeset since this is a regression from the current
main, and it hasn't been released yet.Fixes #9050
Test Plan
snapshots
Docs