fix(linter): useExhaustiveDependencies proper rest parameters handling, fixes #8967

[mdevils]

Summary

Fixed #8967. useExhaustiveDependencies no longer reports false positives for variables destructured from a rest pattern.

Test Plan

Test is included.

Docs

Changeset is included.

[changeset-bot]

🦋 Changeset detected

Latest commit: 402658a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 13 packages

Name	Type
@biomejs/biome	Patch
@biomejs/cli-win32-x64	Patch
@biomejs/cli-win32-arm64	Patch
@biomejs/cli-darwin-x64	Patch
@biomejs/cli-darwin-arm64	Patch
@biomejs/cli-linux-x64	Patch
@biomejs/cli-linux-arm64	Patch
@biomejs/cli-linux-x64-musl	Patch
@biomejs/cli-linux-arm64-musl	Patch
@biomejs/wasm-web	Patch
@biomejs/wasm-bundler	Patch
@biomejs/wasm-nodejs	Patch
@biomejs/backend-jsonrpc	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[coderabbitai]

Walkthrough

This pull request fixes false positives in the useExhaustiveDependencies lint rule when variables are destructured from rest patterns. Changes include updates to the get_single_pattern_member function to recognise REST and SHORTHAND properties within object binding patterns, and modifications to the GetSinglePatternMemberResult::Member enum variant to wrap the member result in an Option type. A test case is added to verify the fix handles rest pattern destructuring correctly.

Possibly related PRs

• fix(linter): useExhaustiveDependencies multiple fixes (fixes #3080, fixes #4248, fixes #5914, fixes #8427, fixes #8484, fixes #3685, fixes #3512, fixes #7982) #8767: Modifies the same get_single_pattern_member function and updates GetSinglePatternMemberResult::Member to hold an Option type for handling rest/shorthand patterns
• fix(lint/useExhaustiveDependencies): correctly fix the dependency list from a shorthand object member #7498: Updates the same use_exhaustive_dependencies lint to correctly handle object shorthand and rest binding patterns in hook dependencies
• fix(linter): useExhaustiveDependencies properly handles aliased destructured object keys when using stableResult configuration #8529: Fixes similar false positives in the useExhaustiveDependencies linter for object destructuring scenarios

Suggested labels

A-Linter, L-JavaScript

Suggested reviewers

• ematipico
• dyc3

🚥 Pre-merge checks | ✅ 4

✅ Passed checks (4 passed)

Check name	Status	Explanation
Linked Issues check	✅ Passed	The PR successfully addresses issue #8967 by modifying pattern matching logic to properly handle rest parameters, preventing false positives in exhaustive dependency checks.
Out of Scope Changes check	✅ Passed	All changes are directly scoped to fixing the useExhaustiveDependencies rule's handling of rest patterns, with supporting test and changeset files.
Title check	✅ Passed	The title directly and accurately describes the main change: fixing the useExhaustiveDependencies rule's handling of rest parameters to resolve issue #8967.
Description check	✅ Passed	The description is clearly related to the changeset, explaining that the PR fixes issue #8967 by correcting how useExhaustiveDependencies handles rest pattern destructuring.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[codspeed-hq]

Merging this PR will not alter performance

✅ 58 untouched benchmarks
⏩ 95 skipped benchmarks¹

---

_{Comparing mdevils:fix/issue-8967 (402658a) with main (8ef9d1d)}

Footnotes

1. 95 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩