fix(html): parsing of directives in svelte#9021
Conversation
🦋 Changeset detectedLatest commit: 2d5ac08 The changes in this PR will be included in the next version bump. This PR includes changesets to release 14 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
| || text.starts_with("use:") | ||
| || text.starts_with("style:") | ||
| || text.starts_with("class:") | ||
| pub(crate) fn is_at_svelte_directive_start(p: &mut HtmlParser) -> bool { |
There was a problem hiding this comment.
It's ugly, but it was the only way to catch bind: and friends without possible false positives
|
Caution Review failedFailed to post review comments WalkthroughThis pull request introduces substantial architectural improvements and feature additions to Biome. Key changes include: a new rule profiling system with per-rule timing metrics; a comprehensive CLI runner refactor introducing trait-based execution (Execution, CommandRunner, TraversalCommand, Crawler, Collector, Finalizer, Handler); JSX factory configuration support replacing CSS modules in the analyser; a new SARIF reporter for diagnostics; refactored reporter abstraction with ReporterWriter interface; new LogOptions and WatcherOptions for daemon/logging configuration; support for class deduplication across utilities; ARIA roles enhancements; and comprehensive new test coverage for various CLI and linting scenarios. Additionally, numerous changesets document new linter rules for HTML and other languages, extended rule domain support (including a new "types" domain), and updates to rule sources including e18e ESLint plugin references. Possibly related PRs
Suggested labels
Suggested reviewers
🚥 Pre-merge checks | ✅ 3 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
🧪 Generate unit tests (beta)
Comment |
Summary
Closes #8902
Test Plan
Added new test
Docs