feat(migrate): some more migration metadata

[dyc3]

Summary

• adds a new rule source for noCommonJs
• adds more metadata for unsupported rules

Test Plan

snapshots, unit tests

Docs

[changeset-bot]

🦋 Changeset detected

Latest commit: 52bc924

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 13 packages

Name	Type
@biomejs/biome	Patch
@biomejs/cli-win32-x64	Patch
@biomejs/cli-win32-arm64	Patch
@biomejs/cli-darwin-x64	Patch
@biomejs/cli-darwin-arm64	Patch
@biomejs/cli-linux-x64	Patch
@biomejs/cli-linux-arm64	Patch
@biomejs/cli-linux-x64-musl	Patch
@biomejs/cli-linux-arm64-musl	Patch
@biomejs/wasm-web	Patch
@biomejs/wasm-bundler	Patch
@biomejs/wasm-nodejs	Patch
@biomejs/backend-jsonrpc	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[coderabbitai]

Walkthrough

The PR introduces migration metadata for ESLint rules by adding a changeset file and registering four new unsupported ESLint rules across multiple sources: func-call-spacing and keyword-spacing for TypeScript, empty-brace-spaces for Unicorn, and func-call-spacing for Vue. Additionally, the no-var-requires rule source is registered with the NoCommonJs lint rule.

Possibly related PRs

• feat(migrate): more unsupported rule metadata for better clarity #8864: Covers overlapping work on unsupported ESLint rules and changeset metadata in the migrate flow with identical module constants
• docs: rules.rs cleanup #8044: Expands RuleSource variants and enhances ESLint source handling infrastructure
• docs: qwik no-react-props rule reference #8210: Modifies ESLint rule source registrations in lint rule declarations

Suggested labels

A-CLI, A-Linter, L-JavaScript, A-Tooling

Suggested reviewers

• ematipico
• Conaclos

🚥 Pre-merge checks | ✅ 2

✅ Passed checks (2 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly identifies the main change as adding migration metadata for ESLint rules, which directly aligns with the changeset and code modifications.
Description check	✅ Passed	The description accurately outlines the pull request objectives: adding a new rule source for noCommonJs and extending migration metadata for unsupported rules, matching the actual changes.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch dyc3/more-migrate-meta

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Actionable comments posted: 1

🤖 Fix all issues with AI agents

In `@crates/biome_js_analyze/src/lint/style/no_common_js.rs`:
- Around line 58-62: Replace the mapping for the TypeScript rule that differs in
coverage: in crates/biome_js_analyze/src/lint/style/no_common_js.rs change the
RuleSource entry RuleSource::EslintTypeScript("no-var-requires").same() to use
.inspired() instead of .same() so that no-var-requires is treated as an inspired
mapping (not identical) to NoCommonJs.

[coderabbitai]

⚠️ Potential issue | 🟡 Minor

🧩 Analysis chain

🌐 Web query:

@typescript-eslint/no-var-requires rule documentation scope behavior

💡 Result:

@typescript-eslint/no-var-requires flags CommonJS “variable requires”—i.e., assigning the result of require() to a variable:

• Reported (invalid): var foo = require('foo'), let foo = require('foo'), const foo = require('foo') (the classic “Require statement not part of import statement” message). [1]
• Allowed (not reported): TypeScript’s import-assignment form import foo = require('foo'), and a side-effect-only require('foo') call (because it’s not a var/let/const assignment). [1]

Scope / what it targets

• The rule’s scope is specifically require() used in a variable declaration/assignment pattern (“var-requires”), not all require() usage. [1]

Options

• allow: string[] — a list of regex patterns (compiled with the u flag) for module specifiers that are allowed to be required (commonly used for things like package.json or certain JSON files). Default: []. [1]

Status / replacement

• The rule is deprecated in favor of @typescript-eslint/no-require-imports. [1]
• no-require-imports is broader: it disallows invoking require() (optionally allowing import ... = require(...) via allowAsImport). [2]

Sources: [1] no-var-requires docs, typescript-eslint.io; [2] no-require-imports docs, typescript-eslint.io.

---

🏁 Script executed:

# Check the NoCommonJs rule definition in the file to understand its scope
fd -t f "no_common_js.rs" crates/biome_js_analyze/src/lint/style/

Repository: biomejs/biome

Length of output: 111

---

🏁 Script executed:

# Read the rule definition to understand what NoCommonJs covers
cat -n crates/biome_js_analyze/src/lint/style/no_common_js.rs | head -100

Repository: biomejs/biome

Length of output: 3961

---

Use .inspired() instead of .same() for no-var-requires.

@typescript-eslint/no-var-requires only flags require() in variable declarations—it doesn't cover module.exports or exports assignments like NoCommonJs does. Since the coverage differs, .inspired() is the more accurate mapping.

🔧 Suggested fix

-            RuleSource::EslintTypeScript("no-var-requires").same(),
+            RuleSource::EslintTypeScript("no-var-requires").inspired(),

🤖 Prompt for AI Agents

In `@crates/biome_js_analyze/src/lint/style/no_common_js.rs` around lines 58 - 62,
Replace the mapping for the TypeScript rule that differs in coverage: in
crates/biome_js_analyze/src/lint/style/no_common_js.rs change the RuleSource
entry RuleSource::EslintTypeScript("no-var-requires").same() to use .inspired()
instead of .same() so that no-var-requires is treated as an inspired mapping
(not identical) to NoCommonJs.

[codspeed-hq]

CodSpeed Performance Report

Merging this PR will not alter performance

_{Comparing dyc3/more-migrate-meta (52bc924) with main (c8dbbbe)}

Summary

✅ 58 untouched benchmarks
⏩ 95 skipped benchmarks¹

Footnotes

1. 95 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩